Repository navigation
Conversation
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
cpruijsen
force-pushed
the
fix/issue-4259
branch
3 times, most recently
from
September 22, 2026 08:47
7e2c5f2 to
1d0778f
Compare
cpruijsen
force-pushed
the
fix/issue-4259
branch
from
October 6, 2026 16:44
1d0778f to
0bffcca
Compare
Contributor
|
eas-cli now uses changesets for changelogs (#4580). The required "Check for a changeset" check fails on PRs that edit To update this PR:
The release adds the PR link and the author to the entry. If this PR needs no changelog entry, revert the |
Author
|
I reverted the CHANGELOG.md edit and added a changeset ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Read
.easignorenext toeas.jsonwhen that file exists, otherwise from the git repository root. Fixes #4259.eas-cli always resolved
.easignoreby joining the filename onto the git repository root (git rev-parse --show-toplevel). A file next toeas.jsonin a monorepo app directory was silently ignored.https://github.com/expo/fyi/blob/main/eas-build-archive.md says: if
EAS_PROJECT_ROOTis unset, place.easignorein the same directory as youreas.json. That path was never consulted. The same lookup is used forrequireCommitpruning (git ls-files --exclude-from), forIgnoreduring the working-tree copy, and forisFileIgnoredAsync. Monorepos with one.easignoreper app had to copy it to the repo root (a race in CI) or disable VCS withEAS_NO_VCS=1 EAS_PROJECT_ROOT=....How
Resolve
.easignorein the EAS project directory when that file exists, otherwise fall back to the repository / copy root. Pattern matching and prefix anchoring are unchanged:git ls-files --exclude-fromstill applies the file to the repo it is listing, andIgnorestill uses an empty prefix against the copy root.VcsClientContextFieldalready had the project directory (the same path used foreas.json) and now passes it intoresolveVcsClient. BothGitClientandNoVcsClientuse it.Project-directory
.easignorewins; git-root file is the fallback. Do not merge with.gitignore. No warning when both files exist (debug log only). Merge with.gitignorewas suggested on the issue. Another option is to warn/error if both files exist. The reporter's patch is lookup-only, and existing tests document that.easignorereplaces.gitignore. Precedence when both exist was listed as an open question and no maintainer has answered it. Can switch to a warn when both exist, or a merge with.gitignore.Test Plan
cd packages/eas-cli && yarn test src/vcs/__tests__/local-test.ts src/vcs/clients/__tests__/noVcs.test.ts src/vcs/clients/__tests__/git.test.ts(56 passed)apps/app-a/.easignoreis used byIgnore,GitClient.isFileIgnoredAsync,GitClient.makeShallowCopyAsync(requireCommittrue and false), andNoVcsClient.isFileIgnoredAsync.easignore; root file is used when the project has none.easignore/.gitignorecases still passeas build:inspect --stage archivefromapps/app-ain a real monorepo, with.easignoreonly next to that app'seas.json