Skip to content

[build-tools] Redact the expo-device-hub session token from the step log - #4608

Closed
krystofwoldrich wants to merge 2 commits into
mainfrom
krystofwoldrich/expo-device-hub-session-logs
Closed

krystofwoldrich wants to merge 2 commits into
mainfrom
krystofwoldrich/expo-device-hub-session-logs

Conversation

@krystofwoldrich

Copy link
Copy Markdown
Contributor

Why

After #4578, expo-device-hub prints its session token in its startup output, which #4525 streams into the step log. This adds the Android token to the redacted secrets, as for iOS.

Merge after #4525 and #4578.

Test Plan

Existing deviceSessionHost tests, typecheck, lint and format check pass.

🤖 Generated with Claude Code

@krystofwoldrich krystofwoldrich added the no changelog PR that doesn't require a changelog entry label Oct 12, 2026
@github-actions

Copy link
Copy Markdown

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@krystofwoldrich
krystofwoldrich marked this pull request as ready for review October 12, 2026 11:24
@krystofwoldrich
krystofwoldrich requested review from gwdp and szdziedzic and removed request for szdziedzic October 12, 2026 11:24
@codecov

codecov Bot commented Oct 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.96%. Comparing base (3f7cfb1) to head (db7977e).

Additional details and impacted files
@@                          Coverage Diff                           @@
##           gwdp/serve-sim-server-log-artifact    #4608      +/-   ##
======================================================================
+ Coverage                               73.96%   73.96%   +0.01%     
======================================================================
  Files                                    1013     1013              
  Lines                                   49406    49407       +1     
  Branches                                10665    10666       +1     
======================================================================
+ Hits                                    36536    36537       +1     
  Misses                                  11878    11878              
  Partials                                  992      992              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gwdp
gwdp force-pushed the gwdp/serve-sim-server-log-artifact branch from 3f7cfb1 to cec2a80 Compare October 15, 2026 01:21
Base automatically changed from gwdp/serve-sim-server-log-artifact to main October 15, 2026 03:34
@krystofwoldrich

Copy link
Copy Markdown
Contributor Author

Note

Claude Code posted this reply on behalf of @krystofwoldrich.

Closing: #4525 and #4578 cover this. #4578 adds the session token to the redacted secrets for both iOS and Android (deviceSessionHost.ts, after the shared token check).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants