Repository navigation
[build-tools] Redact the expo-device-hub session token from the step log - #4608
Closed
krystofwoldrich wants to merge 2 commits into
Closed
krystofwoldrich wants to merge 2 commits into
krystofwoldrich wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
krystofwoldrich
marked this pull request as ready for review
October 12, 2026 11:24
krystofwoldrich
requested review from
gwdp and
szdziedzic
and removed request for
szdziedzic
October 12, 2026 11:24
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## gwdp/serve-sim-server-log-artifact #4608 +/- ##
======================================================================
+ Coverage 73.96% 73.96% +0.01%
======================================================================
Files 1013 1013
Lines 49406 49407 +1
Branches 10665 10666 +1
======================================================================
+ Hits 36536 36537 +1
Misses 11878 11878
Partials 992 992 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gwdp
approved these changes
Oct 12, 2026
gwdp
force-pushed
the
gwdp/serve-sim-server-log-artifact
branch
from
October 15, 2026 01:21
3f7cfb1 to
cec2a80
Compare
Contributor
Author
|
Note Claude Code posted this reply on behalf of @krystofwoldrich. Closing: #4525 and #4578 cover this. #4578 adds the session token to the redacted secrets for both iOS and Android ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After #4578, expo-device-hub prints its session token in its startup output, which #4525 streams into the step log. This adds the Android token to the redacted secrets, as for iOS.
Merge after #4525 and #4578.
Test Plan
Existing
deviceSessionHosttests, typecheck, lint and format check pass.🤖 Generated with Claude Code