Skip to content

[eas-cli] Add interactive simulator control - #4643

Draft
gwdp wants to merge 2 commits into
gwdp/start-import-second-20261018from
gwdp/simulator-control-interactive
Draft

gwdp wants to merge 2 commits into
gwdp/start-import-second-20261018from
gwdp/simulator-control-interactive

Conversation

@gwdp

@gwdp gwdp commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Why

Find and repeat simulator actions from the terminal.

How

Search the live catalog, enter parameters, run one action, and return to the picker. Show the session, project, device/runtime and IDs using existing prompts and ora. Restore the terminal on Exit, Ctrl-C, session stop or failure. Keep compact discovery with --list and per-action --help; explain unavailable previews with session-check/start guidance instead of a raw 404.

Test Plan

Codex: 681 simulator/help tests, production build, lint and formatting passed for the combined stack. Three independent adversarial passes found no new issues. Earlier Tart/serve-sim QA covered the header, keyboard readback, screenshot saving and terminal restoration. Hosted QA was not rerun for this restack; CI runs separately.

Terminal video · QA evidence

Interactive controls

Authorship and LLM use

Gabe chose the looping flow and terminal design. Codex implemented it and fixed verified findings from independent agent and Devin reviews. Codex then preserved merged discovery/help while rebasing on main and added unavailable-preview guidance with failing-first regressions. Codex then moved the optional menu, prompts and session watcher above both import layers; shared execution remains below. Final human code review pending.

— Codex

@gwdp

This comment has been minimized.

@gwdp
gwdp added this pull request to stack #4645 October 16, 2026 07:09
@gwdp

This comment has been minimized.

@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

devin-ai-integration[bot]

This comment was marked as outdated.

@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.73371% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.42%. Comparing base (879a139) to head (49e716d).

Files with missing lines Patch % Lines
...ckages/eas-cli/src/simulator/controlInteractive.ts 97.29% 5 Missing ⚠️
packages/eas-cli/src/commands/simulator/control.ts 96.67% 1 Missing and 1 partial ⚠️
packages/eas-cli/src/simulator/controlSession.ts 98.60% 1 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                          @@
##           gwdp/start-import-second-20261018    #4643      +/-   ##
=====================================================================
+ Coverage                              76.27%   76.42%   +0.16%     
=====================================================================
  Files                                   1080     1083       +3     
  Lines                                  54062    54400     +338     
  Branches                               11928    12041     +113     
=====================================================================
+ Hits                                   41230    41570     +340     
+ Misses                                 11852    11849       -3     
- Partials                                 980      981       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

Base automatically changed from gwdp/simulator-control to main October 17, 2026 22:38
@gwdp
gwdp force-pushed the gwdp/simulator-control-interactive branch from 460b630 to d3b726c Compare October 17, 2026 23:17
@gwdp

This comment has been minimized.

@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

@gwdp
gwdp force-pushed the gwdp/simulator-control-interactive branch from d3b726c to fc7e96a Compare October 19, 2026 04:48
@gwdp
gwdp removed this pull request from stack #4645 October 19, 2026 04:49
@gwdp
gwdp changed the base branch from main to gwdp/start-import-second-20261018 October 19, 2026 04:51
@gwdp
gwdp added this pull request to stack #4688 October 19, 2026 04:52
@gwdp

This comment has been minimized.

@gwdp
gwdp force-pushed the gwdp/simulator-control-interactive branch from fc7e96a to 96a5a97 Compare October 19, 2026 05:05
@gwdp

This comment has been minimized.

@gwdp
gwdp force-pushed the gwdp/simulator-control-interactive branch 2 times, most recently from 360ba9f to 7a599ef Compare October 19, 2026 05:31
@gwdp
gwdp force-pushed the gwdp/simulator-control-interactive branch from 7a599ef to 51dc282 Compare October 19, 2026 05:40
@gwdp
gwdp force-pushed the gwdp/simulator-control-interactive branch from 51dc282 to 44b8100 Compare October 20, 2026 18:44
@gwdp
gwdp force-pushed the gwdp/simulator-control-interactive branch 2 times, most recently from b5228aa to 9fe1ea9 Compare October 20, 2026 19:06
@gwdp
gwdp force-pushed the gwdp/simulator-control-interactive branch from 9fe1ea9 to 49e716d Compare October 29, 2026 20:37
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding a changeset!

@gwdp

gwdp commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Codex restacked the interactive layer above both imports and preserved main’s upload-path validation and help. The combined stack passed all 876 simulator/help tests, production build, typecheck, lint and formatting. This PR remains draft; no fresh hosted QA or human review for this rebase.

— Codex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant