Skip to content

[eas-cli] Import simulator control configurations - #4644

Merged
gwdp merged 0 commit into
gwdp/simulator-control-interactivefrom
gwdp/simulator-control-import
Oct 19, 2026
Merged

gwdp merged 0 commit into
gwdp/simulator-control-interactivefrom
gwdp/simulator-control-import

Conversation

@gwdp

@gwdp gwdp commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Why

Apply repeatable simulator setup from a file.

How

--import <file> validates an ordered JSON configuration, runs it immediately and exits. Show session/device details, file destinations, progress and results; stop on failure and identify skipped actions. Support --json for automation.

Test Plan

Codex: 626 simulator tests, production build, changed-file lint and formatting passed after rebasing. Earlier Tart/serve-sim QA verified seven imported actions, exact app-file readback, in-app contents and JSON success/failure output. Earlier 62-action QA remains separate. Hosted import QA was not rerun for this revision. CI runs separately.

Terminal video · QA evidence · Imported file in the app

Import progress

Authorship and LLM use

Gabe chose ordered JSON and approved the file-only terminal experience. Codex implemented it and fixed verified findings from independent agent and Devin reviews, including help formatting and directory-output hints. Codex rebased this draft and retained the merged discovery/help and inherited preview-error handling. Final human code review pending.

— Codex

@gwdp
gwdp added this pull request to stack #4645 October 16, 2026 07:09
@gwdp

gwdp commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor Author

Codex implemented file-only import with the shared session/device header and readable file destinations. Three local agent reviews were adjudicated; verified help formatting and directory-output hint issues were fixed, and display names were bounded/sanitized. Fresh Tart import verified exact app-file readback and in-app contents; JSON success/failure stdout parsed cleanly.

213 focused tests passed; typecheck, build, lint and formatting passed. Session/auth use local fixtures; hosted EAS and final human code review remain pending. Updated video and QA evidence.

Merged current main through the stack, preserving both test additions in the preview-utils conflict. All 607 simulator tests, typecheck and build passed afterward. Control/UI source is unchanged from the recordings.

— Codex

@gwdp

This comment has been minimized.

@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

devin-ai-integration[bot]

This comment was marked as outdated.

@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.26590% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.45%. Comparing base (d3b726c) to head (a71c976).

Files with missing lines Patch % Lines
packages/eas-cli/src/simulator/controlConfig.ts 97.85% 2 Missing ⚠️
packages/eas-cli/src/commands/simulator/control.ts 98.75% 1 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                           @@
##           gwdp/simulator-control-interactive    #4644      +/-   ##
======================================================================
+ Coverage                               75.38%   75.45%   +0.08%     
======================================================================
  Files                                    1055     1056       +1     
  Lines                                   52287    52453     +166     
  Branches                                11463    11507      +44     
======================================================================
+ Hits                                    39410    39573     +163     
- Misses                                  11885    11888       +3     
  Partials                                  992      992              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

devin-ai-integration[bot]

This comment was marked as outdated.

@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

@gwdp

This comment has been minimized.

@devin-ai-integration

Copy link
Copy Markdown

Starting Devin Review.

Devin Review

@gwdp

This comment has been minimized.

@devin-ai-integration

Copy link
Copy Markdown

Starting Devin Review.

Devin Review

@gwdp
gwdp force-pushed the gwdp/simulator-control-import branch from fae8c09 to a71c976 Compare October 17, 2026 23:17
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding a changeset!

@gwdp

gwdp commented Oct 17, 2026

Copy link
Copy Markdown
Contributor Author

Updated a71c97655. Rebased on the refreshed interactive layer, preserving file-only imports and the merged discovery/help behavior. The preview-error fix is inherited. All 626 simulator tests, production build, changed-file lint and formatting passed. Still draft.

— Codex

@gwdp

gwdp commented Oct 18, 2026

Copy link
Copy Markdown
Contributor Author

/devin review

Please review current head a71c976 against its stack parent. Gabe requested another review round across the in-flight simulator command work. Review codebase conventions, lifecycle/error handling, cancellation and configuration preflight. The separate command feedback fixes are stacked in #4679; distinguish that follow-up from this layer.

— Codex

@devin-ai-integration

Copy link
Copy Markdown

Starting Devin Review.

Devin Review

@gwdp
gwdp merged commit 0b4709f into main Oct 19, 2026
@gwdp
gwdp deleted the gwdp/simulator-control-import branch October 19, 2026 04:48
@gwdp
gwdp force-pushed the gwdp/simulator-control-import branch from a71c976 to 0b4709f Compare October 19, 2026 04:48
@gwdp

gwdp commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

Codex pushed reordered heads before updating stack bases, causing GitHub to mark this PR merged into a feature branch. Its changes were not merged into main. Continued in replacement draft #4686.

— Codex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant