Repository navigation
[eas-cli] Import simulator control configurations - #4644
Conversation
|
Codex implemented file-only import with the shared session/device header and readable file destinations. Three local agent reviews were adjudicated; verified help formatting and directory-output hint issues were fixed, and display names were bounded/sanitized. Fresh Tart import verified exact app-file readback and in-app contents; JSON success/failure stdout parsed cleanly. 213 focused tests passed; typecheck, build, lint and formatting passed. Session/auth use local fixtures; hosted EAS and final human code review remain pending. Updated video and QA evidence. Merged current main through the stack, preserving both test additions in the preview-utils conflict. All 607 simulator tests, typecheck and build passed afterward. Control/UI source is unchanged from the recordings. — Codex |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gwdp/simulator-control-interactive #4644 +/- ##
======================================================================
+ Coverage 75.38% 75.45% +0.08%
======================================================================
Files 1055 1056 +1
Lines 52287 52453 +166
Branches 11463 11507 +44
======================================================================
+ Hits 39410 39573 +163
- Misses 11885 11888 +3
Partials 992 992 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fae8c09 to
a71c976
Compare
|
✅ Thank you for adding a changeset! |
|
Updated a71c97655. Rebased on the refreshed interactive layer, preserving file-only imports and the merged discovery/help behavior. The preview-error fix is inherited. All 626 simulator tests, production build, changed-file lint and formatting passed. Still draft. — Codex |
|
/devin review Please review current head a71c976 against its stack parent. Gabe requested another review round across the in-flight simulator command work. Review codebase conventions, lifecycle/error handling, cancellation and configuration preflight. The separate command feedback fixes are stacked in #4679; distinguish that follow-up from this layer. — Codex |
a71c976 to
0b4709f
Compare
|
Codex pushed reordered heads before updating stack bases, causing GitHub to mark this PR merged into a feature branch. Its changes were not merged into — Codex |
Why
Apply repeatable simulator setup from a file.
How
--import <file>validates an ordered JSON configuration, runs it immediately and exits. Show session/device details, file destinations, progress and results; stop on failure and identify skipped actions. Support--jsonfor automation.Test Plan
Codex: 626 simulator tests, production build, changed-file lint and formatting passed after rebasing. Earlier Tart/serve-sim QA verified seven imported actions, exact app-file readback, in-app contents and JSON success/failure output. Earlier 62-action QA remains separate. Hosted import QA was not rerun for this revision. CI runs separately.
Terminal video · QA evidence · Imported file in the app
Authorship and LLM use
Gabe chose ordered JSON and approved the file-only terminal experience. Codex implemented it and fixed verified findings from independent agent and Devin reviews, including help formatting and directory-output hints. Codex rebased this draft and retained the merged discovery/help and inherited preview-error handling. Final human code review pending.
— Codex