Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gwdp
added this pull request to stack #4606
October 17, 2026 01:32
gwdp
removed this pull request from stack #4606
October 17, 2026 01:44
gwdp
added this pull request to stack #4670
October 17, 2026 01:44
gwdp
force-pushed
the
gwdp/argent-startup-stop-20261016
branch
from
October 20, 2026 19:04
c99d35f to
8239a5c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## gwdp/agent-device-startup-stop-20261016 #4667 +/- ##
===========================================================================
+ Coverage 75.38% 75.39% +0.01%
===========================================================================
Files 1055 1056 +1
Lines 52359 52370 +11
Branches 11390 11387 -3
===========================================================================
+ Hits 39466 39477 +11
Misses 11904 11904
Partials 989 989 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gwdp
force-pushed
the
gwdp/argent-startup-stop-20261016
branch
from
October 20, 2026 20:16
8239a5c to
9a8519f
Compare
gwdp
marked this pull request as ready for review
October 20, 2026 20:46
|
✅ Thank you for adding a changeset! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A Stop request that arrives while an Argent session is still starting does not end startup. The worker goes on through Simulator preparation, the Argent setup commands and the tool-server start, and then reports the session as ready. #4666 fixes this for agent-device. This PR does the same for Argent.
How
watchDeviceRunSessionStartup), with acreateStartupTasksstartup signal, like agent-device.Test Plan
src/stepstests on this commit (1946 passed, 8 skipped), and the root build, typecheck, oxlint, oxfmt and Lerna tests on the top of the stack (2511 passed, 8 skipped).9a8519f. Codecov reports all changed lines covered.Authorship and LLM use
Gabe asked for Stop coverage for every Simulator session type, with one PR per type. Codex wrote the first version, which added the startup watch in this PR, and Devin found no issues in that version. Claude Code rebased it onto the current #4666. On Gabe's request, Claude Code moved the watch into #4666 and gave the three session types the same startup code. Gabe reviewed the final diffs and can answer questions.
Generated with T3 Code, using Claude Code.