Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
✅ Thank you for adding a changeset! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4699 +/- ##
==========================================
+ Coverage 75.29% 75.29% +0.01%
==========================================
Files 1053 1053
Lines 52148 52149 +1
Branches 11387 11388 +1
==========================================
+ Hits 39260 39261 +1
Misses 11900 11900
Partials 988 988 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
I tried several Appium iOS sessions and found that the app the session launched was gone once a WebDriver session started, unless the client set
appium:isHeadless: true.Since #4603, serve-sim starts the Simulator and the app while Appium is being set up. With that concurrent startup, XCUITest restarts the Simulator when the WebDriver session starts, which closes the launched app and drops its launch arguments and deep link. Session creation also took 24–28 s instead of 6 s. With
appium:isHeadless: true, the session started in 6 s and the app stayed in the foreground.How
Add
appium:isHeadless: trueto Appium's--default-capabilitiesfor iOS. Default capabilities apply to every client session, including clients that build their own capabilities instead of usingAPPIUM_CAPS. A client can still override it. EAS VMs never show the Simulator window, so the capability matches how sessions run. Android is unchanged.Test Plan
startAppiumRemoteSessiontests: 29 passed. The two iOS default-capability tests fail without the change; the Android test checks that Android does not get the capability.f94c4f1, and Codecov reports all changed lines covered.isHeadlesslost the app; one withappium:isHeadless: truepassed (app in the foreground, tap worked).isHeadless.Authorship and LLM use
Gabe found the problem and set the direction. Claude Code ran the hosted sessions, narrowed the trigger to WebDriver session start, and wrote this change and its tests. Devin review found no issues. Gabe reviewed the final diff and can answer questions.
Generated with T3 Code, using Claude Code.