Repository navigation
[build-tools] Keep default Android animation scales in device run sessions - #4701
Closed
krystofwoldrich wants to merge 1 commit into
Closed
krystofwoldrich wants to merge 1 commit into
krystofwoldrich wants to merge 1 commit into
Conversation
…sions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
✅ Thank you for adding a changeset! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4701 +/- ##
==========================================
+ Coverage 75.30% 75.30% +0.01%
==========================================
Files 1053 1053
Lines 52170 52174 +4
Branches 11356 11359 +3
==========================================
+ Hits 39281 39285 +4
Misses 11901 11901
Partials 988 988 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Note Claude Code posted this reply on behalf of @krystofwoldrich. Replaced by https://github.com/expo/universe/pull/32516, which sets the existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Android simulator sessions show Reduce motion as on right after boot, because we force the animation scales to 0 when the emulator starts. That write came from eas-cli#3557 to make Maestro tests faster and less flaky, but sessions should show the device's real default instead.
How
The emulator start helper now takes an option to skip the animation scale write, and it still defaults to the old behavior. The agent-device session turns it off, and the shared emulator step turns it off when the job has a device run session ID, which www already sets for every session. The
ANDROID_EMULATOR_ADJUST_ANIMATION_SCALEenv var still works as before for everything else.Test plan
Start an Android simulator session on staging from expo.dev and check that Reduce motion is off and
adb shell settings get global transition_animation_scaledoes not print 0. Then run a Maestro test job on Android and check its log still says it disabled the window and transition animations.