Skip to content

[build-tools] Keep default Android animation scales in device run sessions - #4701

Closed
krystofwoldrich wants to merge 1 commit into
mainfrom
krystofwoldrich/session-emulator-animations
Closed

krystofwoldrich wants to merge 1 commit into
mainfrom
krystofwoldrich/session-emulator-animations

Conversation

@krystofwoldrich

Copy link
Copy Markdown
Contributor

Why

Android simulator sessions show Reduce motion as on right after boot, because we force the animation scales to 0 when the emulator starts. That write came from eas-cli#3557 to make Maestro tests faster and less flaky, but sessions should show the device's real default instead.

How

The emulator start helper now takes an option to skip the animation scale write, and it still defaults to the old behavior. The agent-device session turns it off, and the shared emulator step turns it off when the job has a device run session ID, which www already sets for every session. The ANDROID_EMULATOR_ADJUST_ANIMATION_SCALE env var still works as before for everything else.

Test plan

Start an Android simulator session on staging from expo.dev and check that Reduce motion is off and adb shell settings get global transition_animation_scale does not print 0. Then run a Maestro test job on Android and check its log still says it disabled the window and transition animations.

…sions

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding a changeset!

@codecov

codecov Bot commented Oct 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.30%. Comparing base (e4bb181) to head (75bf520).

Files with missing lines Patch % Lines
...-tools/src/steps/functions/startAndroidEmulator.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4701      +/-   ##
==========================================
+ Coverage   75.30%   75.30%   +0.01%     
==========================================
  Files        1053     1053              
  Lines       52170    52174       +4     
  Branches    11356    11359       +3     
==========================================
+ Hits        39281    39285       +4     
  Misses      11901    11901              
  Partials      988      988              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@krystofwoldrich

Copy link
Copy Markdown
Contributor Author

Note

Claude Code posted this reply on behalf of @krystofwoldrich.

Replaced by https://github.com/expo/universe/pull/32516, which sets the existing ANDROID_EMULATOR_ADJUST_ANIMATION_SCALE=false for device run sessions instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant