Skip to content

[ci] Format the generated changelog before release - #4773

Merged
douglowder merged 7 commits into
mainfrom
gwdp/validate-single-line-changesets
Oct 28, 2026
Merged

douglowder merged 7 commits into
mainfrom
gwdp/validate-single-line-changesets

Conversation

@gwdp

@gwdp gwdp commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Why

I broke the changelog with a multiline changeset in #4683, and the release failed fmt:check.

How

Format the generated changelog before committing the release so multiline changesets pass fmt:check.

Like expo/expo, we configure Changesets to run Oxfmt during changeset version. That formats the package changelogs, but we write our custom root changelog afterward. Run Oxfmt on it too, adding the missing blank line before the next bullet while preserving multiline entries.

Authorship and LLM use

I wrote this description and reviewed the changes. Codex implemented and tested the change.

@gwdp gwdp changed the title Validate single-line changeset bodies and fix changelog formatting Reject multiline changeset bodies in PR checks Oct 27, 2026
@gwdp gwdp added the no changelog PR that doesn't require a changelog entry label Oct 27, 2026
@gwdp gwdp removed the no changelog PR that doesn't require a changelog entry label Oct 27, 2026
@gwdp gwdp changed the title Reject multiline changeset bodies in PR checks [ci] Reject multiline changesets and fix changelog Oct 27, 2026
@gwdp
gwdp requested a review from douglowder October 27, 2026 22:32
@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.75%. Comparing base (864b11e) to head (6c2342b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4773   +/-   ##
=======================================
  Coverage   75.75%   75.75%           
=======================================
  Files        1059     1059           
  Lines       52813    52813           
  Branches    11566    11566           
=======================================
  Hits        40001    40001           
  Misses      11832    11832           
  Partials      980      980           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gwdp
gwdp marked this pull request as ready for review October 27, 2026 22:44
@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread CHANGELOG.md Resolved
@gwdp
gwdp marked this pull request as draft October 27, 2026 23:35
@gwdp

gwdp commented Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

Updating to allow multi-line instead and align with expo/expo

@gwdp gwdp changed the title [ci] Reject multiline changesets and fix changelog [ci] Format the generated changelog before release Oct 27, 2026
@github-actions

Copy link
Copy Markdown

❌ This PR needs a valid changeset. Run yarn changeset, select the changed packages and the bump type, and commit the new file in .changeset/. Do not edit CHANGELOG.md: the release generates it. The "Validate changesets" step log lists the problems.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR. The label does not allow edits to CHANGELOG.md files.

@gwdp
gwdp marked this pull request as ready for review October 27, 2026 23:42
@douglowder
douglowder merged commit ee4f03d into main Oct 28, 2026
11 of 12 checks passed
@douglowder
douglowder deleted the gwdp/validate-single-line-changesets branch October 28, 2026 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants