Repository navigation
Require ezmsg 3.10.0b5 and ezmsg-baseproc 1.15.0 - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ezmsg-baseproc>=1.15.0: its hash witness no longer holds the first message's axes, which pinned cross-process shared memory and killed the subscriber's channel when the publisher grew it (Cross-process SHM grow kills the subscriber channel (BufferError) when a received message is still referenced ezmsg#272, Hash witness retains the first message's axes, pinning cross-process SHM (causes ezmsg#272) ezmsg-baseproc#17). 1.15.0 itself requires ezmsg 3.10.0b5.ezmsg>=3.10.0b5: SHM hardening (#272), coordinate-axis elision across processes, and fingerprints computed when pickling. Note that SHM-delivered messages are now read-only; a scan found no in-place writes to received data in this repo.ezmsg-sigproc>=3.10.0floor was already compatible with baseproc'sstream_dimrename.Tested locally against ezmsg 3.10.0b5 + ezmsg-baseproc 1.15.0 + ezmsg-sigproc 3.10.0: everything outside
tests/integrationpasses (363 passed, 24 skipped).Integration tests hang on my machine either way:
test_torch_model_unit_systemandtest_refit_kalman_systemboth stall inez.runidentically on ezmsg 3.10.0b4 + baseproc 1.14.0, so it's unrelated to this bump. Worth checking whether CI hangs too.