Repository navigation
Label the sweep's amplitude range with the stream's unit - #14
Merged
Merged
Conversation
phosphor's controls bar now shows the amplitude range as an editable "± value" field, but cannot know the unit -- that is a property of the signal, which arrives on the shmem metadata. ShmemSweepWidget passes shape.unit through when it builds the controls and when the stream changes in place. Requires phosphor>=0.11.0 for set_amplitude_unit. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes the stream's unit (
StreamShape.unit) to phosphor's controls bar, which now shows the amplitude range as an editable± valuefield (ezmsg-org/phosphor#10). Set on build and when the stream changes in place, not every tick.Pins
phosphor>=0.11.0in thesigmonandviewerextras (0.11.0 is on PyPI).Tested: 91 tests pass against phosphor 0.11.0 from PyPI; exercised in a downstream timeseries viewer on live data.