Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This whole render queue heredoc indentation hack originated several years ago, and in the meantime the heredoc machinery has changed a good bit in such a way that AFAICT obviates this. From my reading of the git history, this originates a pretty long ways back to maybe even before breakables were really used, and the additional indent was used to get heredocs in method calls to render the parens at the right indentation level. The addition of breakables (which handle their own indentation) was why this duplication existed. Regardless, I think the machinery around breakables/call chains/etc. sufficiently handles its own indentation nowadays, so the duplicate indentation is just vestigial and can be removed.
More importantly, it runs on literally every token in the render queue, so every one does another token read + pattern match, which is part of why
render_asis currently a huge chunk of the runtime. Cutting this out is just a step towards making the render queue much more efficient.