Repository navigation
fix(plugins/k8saudit-eks): read shift as seconds - #1607
Open
gustavoortega wants to merge 1 commit into
Open
gustavoortega wants to merge 1 commit into
gustavoortega wants to merge 1 commit into
Conversation
The shift option is documented in seconds, but its value was passed to the CloudWatch Logs client as a time.Duration, i.e. nanoseconds. A configured shift of 10 started the first read 10 ns in the past instead of 10 s. Multiply by time.Second and cover it with a test that runs Plugin.Open against a fake CloudWatch Logs endpoint. Signed-off-by: Gustavo Ortega <5921963+gustavoortega@users.noreply.github.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gustavoortega The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
Welcome @gustavoortega! It looks like this is your first PR to falcosecurity/plugins 🎉 |
Rules files suggestions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
shiftis documented in seconds, butOpenpasses it as a baretime.Duration, soshift: 10is 10 ns. The test checks the firstFilterLogEventsStartTime against a fake endpoint.Which issue(s) this PR fixes:
Refs #807