Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fastify accepts
methodas a string or as an array, but theonRoutehook compares it to'GET'directly. A websocket route declared with an array is rejected, even when it only listsGET:The hook now normalizes
methodto an array:HEADkeeps returning early, as it does for the string form;GETorHEADstill throws the same error;['GET']and['GET', 'HEAD']are accepted and upgrade likemethod: 'GET'.Tests cover both accepted arrays end to end with
injectWS, and['GET', 'POST']still throwing.npm testpasses, including 100% coverage and the type tests, and so doeseslint.Checklist
npm run test