Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #156 +/- ##
============================================
+ Coverage 81.76% 82.74% +0.98%
- Complexity 525 579 +54
============================================
Files 52 58 +6
Lines 1771 1930 +159
Branches 179 193 +14
============================================
+ Hits 1448 1597 +149
- Misses 234 242 +8
- Partials 89 91 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| /** | ||
| * Specifies the XGBoost algorithms that can be imported and trained through this provider. | ||
| * | ||
| * @since 1.0.0 |
Collaborator
There was a problem hiding this comment.
Not true, also, not needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new OpenML provider, openml-xgboost, built directly on the upstream XGBoost JVM binding (ml.dmlc:xgboost4j_2.12:3.4.0) to be a replacement of the H2O-embedded XGBoost.
Phase 1 covers:
Key classes
Native runtime
Dependency handling (Kryo)
xgboost4j_2.12 transitively pulls Kryo 5, whose com.esotericsoftware.kryo.Kryo collides on the classpath with the Kryo 4 (kryo-shaded) used by Spark/consumers (Kryo 5 removed the nested Kryo.DefaultInstantiatorStrategy). Since Booster implements com.esotericsoftware.kryo.KryoSerializable, kryo must still be
present at class-load. Resolution: exclude kryo from the xgboost4j dependency and re-declare it in provided scope — available for this module's own compile/tests, not propagated transitively to consumers (which supply their own Kryo).
Testing