Repository navigation
Bundle OpenCodeReview v1.12.12 (accept unlisted models) - #4
Merged
Merged
Conversation
ocr v1.12.12 no longer rejects a --model that is missing from a built-in provider's suggested list; it warns and leaves validation to the provider. With v1.12.10, a review configured with provider: openai-responses, model: gpt-6.1-sol failed with 'model "gpt-6.1-sol" is not available for provider "openai-responses"'. - internal/ocrbin/VERSION: v1.12.10 -> v1.12.12 (Docker image and release binaries). - builtinProviders: the preset registry is unchanged in v1.12.12 (29 providers); only the version in the comment changes. - README / example config: llm.model can be any ID the provider serves. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- README: unlisted models work with the bundled OCR (v1.12.12+); an older ocr on the PATH or set via ocr.binary may still reject them. - Comments in config.go and ocrbin.go refer to internal/ocrbin/VERSION instead of repeating the version. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
pruefbyte 0.1.0 bundles OpenCodeReview (ocr) v1.12.10. That version rejects any
--modelthat is missing from a built-in provider's model list. A CI review configured withprovider: openai-responses,model: gpt-6.1-solfails with:What changed in ocr (v1.12.10 → v1.12.12)
The diff is 6 commits (compare):
fix(llm): allow unlisted OpenRouter model overrides(#1610)internal/llm/resolver.go, a--modelthat is not listed for a built-in provider no longer fails. ocr now prints[ocr] WARNING: model "…" is not in the suggested models for provider "…"; the provider will validate itand sends the request.openai-responseslist itself is unchanged.feat(allowlist): add Jinja template support(#1056).jinja2and.j2files are now reviewed, with a new built-in rule (jinja.md).makeoutput name (#1573)Checked against what pruefbyte relies on:
sha256sum.txtformat: unchanged. The Dockerfile andgo run ./internal/ocrbin/fetchwork as before.--provider/--modelkeep their meaning.builtinProvidersalready matched it; only the version in its comment changes.Changes in this PR
internal/ocrbin/VERSION:v1.12.10→v1.12.12. This file drives both the Docker image and the release binaries.internal/config/config.goandinternal/ocrbin/ocrbin.go.README.mdandpruefbyte.example.yml:llm.modelcan be any ID the provider serves; ocr's built-in lists are only suggestions.pruefbyte itself never validated the model against a list; it only requires
llm.modelto be set. No behaviour change beyond the ocr bump.Verification
gofmt -l .prints nothing.golangci-lint run ./...(v2.14.0): 0 issues.go test -race ./...: all packages pass.go vetpasses with and without-tags embedocr.go run ./internal/ocrbin/fetchdownloaded all six v1.12.12 binaries and verified each against the releasesha256sum.txt.goreleaser release --snapshot --cleanproduced all six archives. The Windows and Linux snapshot binaries both reportocr v1.12.12 (built in)..pruefbyte.ymlwithprovider: openai-responses,model: gpt-6.1-sol, runningpruefbyte local --target mainwith a dummy key:model "gpt-6.1-sol" is not available for provider "openai-responses", reproducing the report.[ocr] WARNING: model "gpt-6.1-sol" is not in the suggested models for provider "openai-responses"; the provider will validate it, gets past "resolve LLM endpoint", and fails at the provider.ocr llm testwith the same config shows the provider's answer:POST https://api.openai.com/v1/responses: 401 Unauthorized … invalid_api_key.docker buildx build --platform linux/amd64,linux/arm64succeeds. Each architecture, loaded and run (arm64 under QEMU), reportsopen-code-review v1.12.12and ships both license texts.Not verified
gpt-6.1-sol: no OpenAI key was available in the environment, so I couldn't confirm the model ID works at OpenAI or that the review output is sound.Release (maintainer, after merge)
Tagging is not part of this PR. After merging, push
v0.1.1on the merge commit. The tag's CI run produces:v0.1.1:pruefbyte_{linux,darwin}_{amd64,arm64}.tar.gz,pruefbyte_windows_{amd64,arm64}.zipandchecksums.txt, all with ocr v1.12.12 embedded.ghcr.io/feinarbyte/pruefbyte:0.1.1,:0.1(moves from 0.1.0), and:sha-<commit>, each for linux/amd64 and linux/arm64.:latestfollowsmain, so it gets ocr v1.12.12 as soon as this PR is merged, before the tag.🤖 Generated with Claude Code