Repository navigation
Conversation
…OS 15 google-cast-sdk 4.8.6 raised its minimum iOS version to 16.0 in both the SRGSSR Swift package and the CocoaPods spec. The open-ended ranges (from: "4.8.4" and ~> 4.8.4) now resolve to it, so a fresh resolution fails against the plugin's own iOS 15.0 platform.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
google-cast-sdk4.8.6 raised its minimum iOS version to 16.0, in both the SRGSSR Swift package (.iOS(.v16)) and the CocoaPods spec ("ios": "16.0"). The plugin's dependency ranges are open-ended (from: "4.8.4"inPackage.swift,~> 4.8.4in the podspec), so a fresh resolution now picks 4.8.6 and fails against the plugin's own iOS 15.0 platform:Apps whose committed
Package.resolved/Podfile.lockalready holds 4.8.4 keep building; any clean resolution (CI without a lockfile, a new app,pod update) breaks.Fix
Cap the dependency below 4.8.6 in both manifests (
"4.8.4"..<"4.8.6"and'>= 4.8.4', '< 4.8.6') until the plugin raises its own floor to iOS 16. Raising the floor instead would be a breaking change for apps that still support iOS 15.Verified with a clean
swift package resolveinios/flutter_chrome_cast(resolves 4.8.4) andpod ipc specon the podspec.Fixes #90