Removed unsafe operations and updated dependencies - #114
Merged
Merged
Conversation
sergkh
commented
Aug 17, 2026
sergkh
commented
Member
- Removed unsafe operations that cleaned all of the recipes or CAP files
- Added confirmation for deletion operations (and --non-interactive flag for scripts)
- Upgraded jackson version
- Removed Java-WebSocket as native java client is good enough. Also added periodical pings, usefull for debugging
- Moved Content-Type setting closer to specific requests as uploading of CAP files were failing because of it
- WS delivery Status message is optional, so fixed reading of it
- Added small usage examples and extended description of some options
- Removed commons dependency – it needed for 2 simple functions.
luisrodero-fidesmo
approved these changes
Aug 17, 2026
luisrodero-fidesmo
left a comment
luisrodero-fidesmo
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍 ! Just added a couple of comments. Also, can you please answer latest Miguel's question in the task?
| private static void printUsageRecipes() { | ||
| System.err.println("Examples:"); | ||
| System.err.println(" Upload a CAP file or recipe:"); | ||
| System.err.println(" fdsm --auth <token> --app-id <app-id> --upload <name>.json"); |
Contributor
There was a problem hiding this comment.
The same command can upload a recipe or a CAP file? No other flag is needed to tell them apart?
Member
Author
There was a problem hiding this comment.
yes, they are differentiated by the file extension
Co-authored-by: Luis Rodero <33416389+luisrodero-fidesmo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.