Repository navigation
feat(timetable-import): split multi-teacher lessons into one lesson per teacher - #397
Conversation
🗑️ Preview removed
Posted by filc-deployer. The preview database is its own container and is |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (4)
🔇 Additional comments (1)
📝 WalkthroughWalkthrough
ChangesLesson draft processing
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The teacher-specific lesson rows appear mergeable after normal checks; no concrete blocking issue was established. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
A source lesson that carries multiple teachers was imported as one row with a
teacherIdsarray, so a substitution or a moved lesson could not target a single one of those teachers.processLessonnow emits one lesson draft per teacher.Changes
processLessonreturnsLessonDraft[]: a lesson resolving to more than one teacher becomes one draft per teacher, keeping the same cohorts, groups, classrooms, subject, day, period, term, week andperiodsPerWeek; 0/1-teacher lessons stay a single draft.scheduleKeyis now<lessonIndex>:<draftIndex>.Verification
bun run lintbun run typecheckbun run build— if bundler config, routers, or server entrypoints changedapps/iris/public/locales/en/translation.jsonandapps/iris/public/locales/hu/translation.json— if user-facing text changedbun run db:generateand committed — if the schema changed