Repository navigation
[ONB-4398] [Compose] Add crossborder transfer cancel/simulate_credit and evm_address beneficiaries - #55
Merged
Conversation
…iciaries Co-authored-by: fin-compose[bot] <255610621+fin-compose[bot]@users.noreply.github.com>
Contributor
Author
|
fin review |
FranciscaOtero
marked this pull request as ready for review
November 16, 2026 12:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexto
The public API (
fintoc-rails7504033b..main, 2026-11-09 to today) added crossborder transfer actions and USDT wallet beneficiaries that the SDK didn't support yet. Creating anevm_addressbeneficiary was impossible because the SDK required US bank fields. This PR closes those gaps.¿Qué hay de nuevo?
client.v2.crossborder.transfers.cancel(id)andsimulate_credit(id)(test mode only) — fintoc-com/fintoc-rails#20605client.v2.crossborder.beneficiaries.createonly requiresholder_typeandaccount_identifier, soevm_addresswallets (account_scheme,network) work;routing_number,bank_nameandaddressare still forwarded when given — fintoc-com/fintoc-rails#20943CrossborderBeneficiaryexposesaccount_scheme,currency,networkandaccount_identifier;to_sshows the wallet forevm_addressCrossborderQuoteexposeskind(locked/indicative)TransferNotCancellableError,CreditAlreadySimulatedError,CreditSimulationUnavailableError,UsdtCollectionAlreadyOpenError,PaymentMethodCanceledError(fintoc-com/fintoc-rails#20993)Tests
Release notes
client.v2.crossborder.transfers.cancelandclient.v2.crossborder.transfers.simulate_credit(test mode only).client.v2.crossborder.beneficiaries.createno longer requiresrouting_number,bank_nameandaddress, so it can createevm_address(USDT wallet) beneficiaries.account_scheme,currency,networkandaccount_identifiertoCrossborderBeneficiary, andkindtoCrossborderQuote.TransferNotCancellableError,CreditAlreadySimulatedError,CreditSimulationUnavailableError,UsdtCollectionAlreadyOpenErrorandPaymentMethodCanceledError.Safety Checks
Consideraciones
Left out, already aligned (released in earlier versions, or the SDK forwards params and keeps nested hashes and string enums as-is):
fintoc_fee(fintoc-com/fintoc-rails#20605, fintoc-com/fintoc-rails#20911, fintoc-com/fintoc-rails#20906), account certificates (fintoc-com/fintoc-rails#20588) andcheckout_sessions.confirm(fintoc-com/fintoc-rails#20935)payment_method_options.card.bins(fintoc-com/fintoc-rails#20751),ui_mode: fieldsandsession_tokenfor payment and setup flows (fintoc-com/fintoc-rails#20837, fintoc-com/fintoc-rails#21037)split.inheritedon invoices (fintoc-com/fintoc-rails#20601) and theinvoice.split_redirectedevent type (fintoc-com/fintoc-rails#20443)cmf_regulated,cmf_registration_numberandcmf_application_proof(fintoc-com/fintoc-rails#20814)setup_intenterror reasons andpayment_method_inactive(fintoc-com/fintoc-rails#20978):PaymentMethodInactiveErroralready existslimit_exceeded(fintoc-com/fintoc-rails#20758),invalid_url(fintoc-com/fintoc-rails#20998) and test retry docs (fintoc-com/fintoc-rails#20836, fintoc-com/fintoc-rails#20874): error classes already existRollback
Revert the PR. It only adds public surface and relaxes required arguments.
🤖🐙 Created with Compose · View session