Repository navigation
[ONB-4421] [Compose] Add payment method installments - #56
Merged
Merged
Conversation
…_allowed error Co-authored-by: fin-compose[bot] <255610621+fin-compose[bot]@users.noreply.github.com>
Contributor
Author
|
fin review |
FranciscaOtero
marked this pull request as ready for review
November 17, 2026 12:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexto
The public API spec (
openapi_spec/main-api.jsonin fintoc-rails, 8a2cfe7..abfc7e7) added a way to ask which installments a saved card accepts. The SDK had no method for it, and a newpayment_intentserror code had no error class.¿Qué hay de nuevo?
client.v2.payment_methods.installments(id, amount:, currency:)→GET /v2/payment_methods/{id}/installments(fintoc-com/fintoc-rails#21303). Returns{ available_installments: [...] }, likemandate_document.Fintoc::Errors::ChargeProcessingFeeNotAllowedErrorfor thecharge_processing_fee_not_allowedcode ofPOST /v2/payment_intents(fintoc-com/fintoc-rails#21411).Already covered by the SDK, no code changes needed:
cancel,simulate_creditandevm_address(fintoc-com/fintoc-rails#20605, #20906, #20911, #20943, #21253).certificate(fintoc-com/fintoc-rails#20588).checkout_sessions.confirm(fintoc-com/fintoc-rails#20935).**params:off_sessionandpayment_method_options.card.installmentsinpayment_intents.create(#21419),payment_method_options.card.binsandui_mode: 'fields'incheckout_sessions.create(#20751, #20837, #21037),data.plaft.cmf_regulated/cmf_registration_numberin onboardings (#20814).payment_methods.list(payment_options: { off_session: true })already sendspayment_options[off_session](#21274); added a test.setup_intent.error_reasonnew values (#20993) and the webhook endpoints 422 (#20758) need no changes:error_reasonis a plain string and the 422 error codes already map to existing classes orFintocError.Tests
installments, its 422 error, theoff_sessionlist filter and the new error class resolution.Release notes
payment_methods.installments(id, amount:, currency:)to get the installments a saved card accepts for an amount.Fintoc::Errors::ChargeProcessingFeeNotAllowedError.Safety Checks
Consideraciones
🤖🐙 Created with Compose · View session