feat: add basic gallery functionality - #1091
Conversation
therobrob
added
enhancement
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi there! 👋 Thank you for your contribution to the FIP Guide! 🚀 Checklist before merging:
|
|
hide scrollbar |
MoritzWeber0
left a comment
MoritzWeber0
left a comment
There was a problem hiding this comment.
LGTM, just three small comments.
| galleryPictures.clientWidth; | ||
|
|
||
| const updateButtonState = () => { | ||
| console.log("updateButtonState"); |
There was a problem hiding this comment.
| console.log("updateButtonState"); |
There is one left-over console.log statement, we should remove it.
| list-style: none; | ||
| border-radius: var(--border-radius-l); | ||
|
|
||
| -ms-overflow-style: none; |
There was a problem hiding this comment.
This is just for Internet explorer support, there are a few other places where we don't have internet explorer support, so we could probably just say that we don't support Internet explorer and safely remove it :)
There was a problem hiding this comment.
What do you think about explicitly adding the list of filenames as a front matter attribute?
Something like:
contentImages:
- image.webp
- image2.webpIt would make it a bit more explicit how to add new images without the assumed image prefix and would enable CMS support. And we could handle the sorting via the ordered list. I just want to hear your thoughts, we can also happily dismiss the proposal or track it as a separate issue.
2 participants
Added gallery feature: