Repository navigation
docs(sdks): document crawl cancellation in the JS and Python SDKs - #1604
Closed
mintlify[bot] wants to merge 1 commit into
Closed
mintlify[bot] wants to merge 1 commit into
mintlify[bot] wants to merge 1 commit into
Conversation
Contributor
Author
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
Contributor
Author
|
Folded into #1754, which consolidates the backlog of gap PRs. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Node and Python SDK pages now explain how to stop a crawl you are waiting on, and what the cancel methods return when the crawl already finished.
The JS SDK's
crawl()now accepts anAbortSignalthat stops polling and cancels the job. Cancelling the task that awaitsAsyncFirecrawl.crawl()now cancels the job too.cancelCrawl/cancel_crawlreturnfalseinstead of throwing when the crawl already completed (409). The "Cancelling a Crawl" sections mentioned none of this.Based on abortable crawl() that cancels its job; cancelCrawl returns false on 409 and cancel the crawl when async crawl() is cancelled; cancel_crawl returns False on 409, both shipped in the current SDK releases.
Needs a human look:
mint validateand the repo's shell checks could not run in the sandbox (validate needs network access).