Skip to content

acp: an agent's writes to an open document are credited to it #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
foxnne merged 2 commits into from
Oct 18, 2026
Merged

acp: an agent's writes to an open document are credited to it #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25950c5
sdk: repin to fizzy SDK 0.2.29, edits credited to the agent
foxnne Oct 17, 2026
bbd0698
merge main (Zig 0.17, SDK 0.2.30) into sdk/repin-0.2.29
foxnne Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/AcpClient.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@ const Session = struct {
/// (`session/resume`), or load it, replaying its history (`session/load`).
can_resume: bool = false,
can_load: bool = false,
/// What `initialize` said the agent is called (`agentInfo`): the label its edits carry beside
/// the person's (`sdk.Author`). Owned; null until it says.
label: ?[]u8 = null,
/// A `session/load` is replaying the conversation: the chat has it already, so the replay is
/// not shown again.
replaying: bool = false,
Expand All @@ -107,6 +110,7 @@ const Session = struct {
if (self.queued) |*q| q.arena.deinit();
if (self.resume_id) |r| self.gpa.free(r);
if (self.folder) |f| self.gpa.free(f);
if (self.label) |l| self.gpa.free(l);
self.pending.deinit(self.gpa);
var it = self.tools.keyIterator();
while (it.next()) |k| self.gpa.free(k.*);
Expand Down Expand Up @@ -600,6 +604,11 @@ fn answered(s: *Session, what: Pending, result: json.Value) void {
const caps = field(result, "agentCapabilities");
s.can_load = if (field(caps, "loadSession")) |v| v == .bool and v.bool else false;
s.can_resume = field(field(caps, "sessionCapabilities"), "resume") != null;
const info = field(result, "agentInfo");
if (str(field(info, "title")) orelse str(field(info, "name"))) |name| {
if (s.label) |l| s.gpa.free(l);
s.label = s.gpa.dupe(u8, name) catch null;
}
openSession(s);
},
.session_new => {
Expand Down Expand Up @@ -881,8 +890,12 @@ fn writeFile(s: *Session, id: json.Value, params: json.Value) void {
const text = str(field(params, "content")) orelse return write(s, acp.writeError, .{ id, -32602, "no content" });
const host = sdk.host();
const arena = host.arena();
if (host.docFromPath(path) != null and callText(arena, "text.write", .{ .path = path, .text = text }) != null) {
return write(s, acp.writeResult, .{ id, .{} });
if (host.docFromPath(path) != null) {
// The edit is this chat's agent's, not the person's: its step carries the agent's name.
const outer = host.act(.{ .kind = .agent, .plugin = "chat", .session = s.chat, .label = s.label orelse "An agent" });
const written = callText(arena, "text.write", .{ .path = path, .text = text });
host.endAct(outer);
if (written != null) return write(s, acp.writeResult, .{ id, .{} });
}
if (std.fs.path.dirname(path)) |dir| std.Io.Dir.cwd().createDirPath(dvui.io, dir) catch {};
std.Io.Dir.cwd().writeFile(dvui.io, .{ .sub_path = path, .data = text }) catch |err|
Expand Down
Loading