Repository navigation
scripts: agent PRs get real titles, a code snippet and notes - #1012
Conversation
Agent-Team: windows Worker: codex
|
TRIAGE @3d0a5f66 auto: mechanical rules met (fizzy-* app author, names work#723, 1 non-test lines <= 400, no risky path). Labelled |
PM note: how this PR will be handledWhat it is for: windows: work-723 Rules that apply: none special. Things to watch (checked by rule):
What happens next:
A living status comment below is kept current. Nothing here is a merge decision. |
Where this PR standsStage: Author's turn What the PM needs before approving (ticks as it is met; the full CI runs only at the end, after the reviews are clean):
Rules that apply: touches CI or workflows; changes agent rules or guides. Reviews at the current commit (
2 earlier reviews are for older commits and will be redone. Latest fixes comment: https://github.com/fizzyedit/work/issues/738#issuecomment-6503844607 (4 findings answered) Updated 2026-10-29 18:03 UTC by the PM. This comment is edited in place. |
Agent-Team: windows Worker: claude
check-pr-body refuses slug titles, a missing or oversized snippet, sections out of order and bad agent-notes JSON; agent-finish titles the claim from the work issue and writes the notes block; template and docs describe the layout. Removes the probe file. Agent-Team: windows Worker: claude Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Part of fizzyedit/work#723
Rework: work#749
In plain words
Pull requests written by our agents now get a title that says what changes, not a branch name like "windows: work-723". Each page also shows a short piece of the actual change, so a visitor can see it, and keeps one fixed place where agents leave notes for each other.
What changes
What you will notice
Agent PR pages read in a fixed order with a snippet of the change and a readable title. Nothing else is visible.
How we know it works
New cases in the worker test script fail without the change: slug titles, a missing snippet, bad notes and a worked example all behave as described.
How this serves fizzy
Quality: public pages that a stranger understands.
Goal
work#723 (PR page v2), reworked after the review of the probe-only commit: implement the real change.
What changed and why
Removed the stray probe file; merged main; extended scripts/check-pr-body (title, What changes snippet, order, agent-notes, draft placeholders), scripts/agent-finish (claim title from the issue, notes block kept across reruns) and the template and docs. Notes JSON is validated with perl's JSON::PP (no jq or python needed). The heading order follows the issue (How we know it works before How this serves fizzy).
How it was verified
bash scripts/test-agent-work.sh (Windows, Git Bash), scripts/check-fmt.sh.
Not done / follow-ups
The issue's "Part of / slot and kind / gate summary inside one details block" regrouping was not done; the existing layout keeps them as before.
Gates: check-fmt.sh and bash scripts/test-agent-work.sh pass. scripts/zb build test-integration fails on this Windows machine in tests unrelated to this change (Recents, PluginLoader, remote, demos, profile; same failures as main).