Skip to content

docs: auto-merge after review; tapes press anchors - #652

Merged
foxnne merged 4 commits into
mainfrom
docs/merge-and-anchor-rules-kgc54p
Oct 19, 2026
Merged

foxnne merged 4 commits into
mainfrom
docs/merge-and-anchor-rules-kgc54p

Conversation

@foxnne

@foxnne foxnne commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Two process rules and a check for the second.

Review (PM reviewer pass)

code-review at medium. Fixed: the soak-only test exempted its only tape and so checked nothing; trace did not update the aim; a keyframe did not reset it; a drop (release) was unchecked; the doc named region.* and region.arrange:<name> as if they existed on main and said soak was already fixed; the paragraph above described offsets the rule now forbids for buttons; the check lived in a test file rather than with the tape; rule 5 did not say who turns auto-merge on. Declined: forbidding non-centre fractions (x, y are relative to the anchor's rect, not a coordinate), and enforcing the rule in Tape.parse (it would refuse live tapes and an agent's strokes; firstButtonOffAnchor is the seam a parse-time check would call).

Local gates on macOS (this reviewer): scripts/check-fmt.sh, zig build test (117/117 steps, includes the new Tape test), zig build test-integration (81/81 steps, every bundled demo passes the check), zig build check-tests-reached. No fizzy launched.

The original author's cloud session had no zig; its CI run was green on the first head.

🤖 Generated with Claude Code

@foxnne
foxnne marked this pull request as ready for review October 19, 2026 16:41
@foxnne
foxnne enabled auto-merge October 19, 2026 17:36

foxnne commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator Author

Integration tests (Linux) fail on 388054b: demos.test.demo: every bundled demo plays… returns error.ButtonOffAnchor with demo 'tour': op 13 presses or releases off an anchor. The other 627 tests pass.

This is the stricter Tape.firstButtonOffAnchor from 388054b catching the bundled tour (it counts release and trace, and a keyframe clears the aim). My original check passed the tour. The first s.click calls in src/editor/demos/tour.zig all aim at a bare tag, so I can't tell by reading which op 13 is. It needs a local run that prints the op's index and target.

I have no zig in this session, so I can't reproduce or push a fix. Auto-merge is on, so this red check holds the merge. Either the tour's op 13 gets re-aimed at an anchor, or the tour is exempted with a reason.


Generated by Claude Code

@foxnne
foxnne force-pushed the docs/merge-and-anchor-rules-kgc54p branch from 388054b to e347b6a Compare October 19, 2026 18:12
claude and others added 3 commits October 19, 2026 13:15
Two process rules, and a test that fails a bundled tape pressing by coordinate.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YMFwhPVgTZ3HuKf89J7hnh
`Tape.firstButtonOffAnchor` replaces the test-local check: a `trace` aims as a `move` does, a
keyframe forgets the aim, and a `release` (a drop) is held to the rule as a press is. The soak
tape's check moves to its verdict test, where it asserts soak still presses off an anchor, so
the exemption cannot outlive #634 unnoticed (the old test listed only soak, and exempted it).
AUTOMATION.md names the anchors that exist (`region:<name>`), says soak is not fixed yet, and
squares the rule with the offset the paragraph above describes; CONTRIBUTING says who turns
auto-merge on.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@foxnne
foxnne force-pushed the docs/merge-and-anchor-rules-kgc54p branch from e347b6a to c1035ca Compare October 19, 2026 18:23
@foxnne
foxnne disabled auto-merge October 19, 2026 18:25
… offer queue

Marking costs nothing without a tape listening: the bubble rects are no longer
computed unless anchors are wanted this frame, and the marks no longer depend on
the offer queue's capacity.
@foxnne
foxnne enabled auto-merge October 19, 2026 18:43
@foxnne
foxnne added this pull request to the merge queue Oct 19, 2026
Merged via the queue into main with commit a4bbf56 Oct 19, 2026
11 checks passed
@foxnne
foxnne deleted the docs/merge-and-anchor-rules-kgc54p branch October 19, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants