Repository navigation
docs: auto-merge after review; tapes press anchors - #652
Conversation
|
Integration tests (Linux) fail on 388054b: This is the stricter I have no Generated by Claude Code |
388054b to
e347b6a
Compare
Two process rules, and a test that fails a bundled tape pressing by coordinate. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YMFwhPVgTZ3HuKf89J7hnh
`Tape.firstButtonOffAnchor` replaces the test-local check: a `trace` aims as a `move` does, a keyframe forgets the aim, and a `release` (a drop) is held to the rule as a press is. The soak tape's check moves to its verdict test, where it asserts soak still presses off an anchor, so the exemption cannot outlive #634 unnoticed (the old test listed only soak, and exempted it). AUTOMATION.md names the anchors that exist (`region:<name>`), says soak is not fixed yet, and squares the rule with the offset the paragraph above describes; CONTRIBUTING says who turns auto-merge on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
e347b6a to
c1035ca
Compare
… offer queue Marking costs nothing without a tape listening: the bubble rects are no longer computed unless anchors are wanted this frame, and the marks no longer depend on the offer queue's capacity.
Two process rules and a check for the second.
CONTRIBUTING.md: auto-merge is turned on only after review is done and the maintainer said yes, by the maintainer or whoever merges on their yes, never by the session that opened the PR (app: a demo sets the person's panes aside #623/app: the history grip fills toward the history's cap #624 merged before review; follow-ups app: a demo's hold on the panes survives a failed copy and a launch #639/app: the history grip counts what the history keeps #640).docs/AUTOMATION.md: a press or release lands on an anchor a widget publishes (region:<name>,fizzy.*), never on the window or an offset from an anchor (layout: a place's arrange button grows out of its corner #634).sdk/tape/Tape.zig:Tape.firstButtonOffAnchorfinds a press or release whose aim (the lastmoveortracesince the last keyframe) has an empty tag or adx/dynudge. Unit-tested in the tape library.tests/demos.zig: every bundled demo is checked with it as it plays.tests/integration.zig: the soak verdict test asserts soak presses only on anchors (firstButtonOffAnchor() == null), now that layout: a place's arrange button grows out of its corner #634 aims it atregion.arrange:Sidebar.ViewDrag.drawZonesmarks each bubble of a place's drop wheel as an anchor while a view is carried over it (drop:center/left/right/top/bottom/remove), andScript.dragtakes aviatarget, since a drop's anchor only appears once the drag has moved. The tour now drops ondrop:rightviaregion:Maininstead of an offset.Review (PM reviewer pass)
code-reviewat medium. Fixed: the soak-only test exempted its only tape and so checked nothing;tracedid not update the aim; a keyframe did not reset it; a drop (release) was unchecked; the doc namedregion.*andregion.arrange:<name>as if they existed on main and said soak was already fixed; the paragraph above described offsets the rule now forbids for buttons; the check lived in a test file rather than with the tape; rule 5 did not say who turns auto-merge on. Declined: forbidding non-centre fractions (x,yare relative to the anchor's rect, not a coordinate), and enforcing the rule inTape.parse(it would refuse live tapes and an agent's strokes;firstButtonOffAnchoris the seam a parse-time check would call).Local gates on macOS (this reviewer):
scripts/check-fmt.sh,zig build test(117/117 steps, includes the newTapetest),zig build test-integration(81/81 steps, every bundled demo passes the check),zig build check-tests-reached. No fizzy launched.The original author's cloud session had no
zig; its CI run was green on the first head.🤖 Generated with Claude Code