Repository navigation
ci: agents work through one rules text and two scripts - #724
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
32fda5f to
26c2f3a
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32fda5f70f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for gate in test test-integration check-web test-sdk-version; do | ||
| run_gate scripts/zb build "$gate" --summary all |
There was a problem hiding this comment.
For any change that fails zig build lint or zig build check-tests-reached, this loop still proceeds to commit, push, and create/update the PR because neither documented gate is invoked. CONTRIBUTING.md lists both as mandatory gates, and check-tests-reached specifically detects tests that the ordinary test build silently omits, so add both to the finish sequence and captured evidence.
AGENTS.md reference: AGENTS.md:L10-L11
Useful? React with 👍 / 👎.
| git worktree add -b "$branch" "$workspace" origin/main >&2 | ||
| cd "$workspace" | ||
| fi | ||
| if [[ $(uname -s) == Linux ]] && ! command -v zig >/dev/null 2>&1; then |
There was a problem hiding this comment.
On Linux with any zig already on PATH, this condition skips cloud-setup.sh even when the executable is not the repository-required 0.17.0. The setup script already detects and replaces mismatched versions, but it is never reached here, so a prepared worker can immediately fail every gate with an unsupported compiler; compare zig version with the pinned version rather than checking only command existence.
Useful? React with 👍 / 👎.
| chmod +x "$tmp/bin/"* "$tmp/repo/scripts/"* | ||
| prepare=$tmp/repo/scripts/agent-prepare | ||
| finish=$tmp/repo/scripts/agent-finish | ||
| "$prepare" ci/example >"$tmp/output" |
There was a problem hiding this comment.
On a Linux host without Zig, this first prepare call follows the new no-Zig path, but the fake workspace does not contain scripts/cloud-setup.sh until the fixture created near the end of the test. The script therefore aborts here with “No such file or directory” before exercising any assertions; provide a fake Zig for the earlier cases or install the cloud-setup fixture before this call.
Useful? React with 👍 / 👎.
2839cfb to
494cfe4
Compare
494cfe4 to
0641c31
Compare
1 participant
Made by OpenAI Codex as a fizzy worker; Claude reviews it before it is marked ready.
Codex's report
Added the shared worker contract, prepare/finish helpers, CONTRIBUTING links, and mock-based script tests.
Passed: formatting, helper tests, shell syntax, native build (73/73), unit tests (171/171), web (44/44), SDK check (35/35). Shellcheck isn’t installed.
Integration failed twice; retry reached 78/81 steps with allocator alignment and double-free panics in unchanged code. Failure log.
No SDK changes, commits, pushes, or PR creation.
🤖 Generated with Claude Code