Repository navigation
ci: Windows provisioning for the self-hosted runner - #740
Merged
Merged
Conversation
foxnne
force-pushed
the
ci/windows-runner-setup
branch
2 times, most recently
from
October 22, 2026 00:47
db4db82 to
58d36ef
Compare
foxnne
force-pushed
the
ci/windows-runner-setup
branch
from
October 22, 2026 00:48
58d36ef to
dd6ae10
Compare
foxnne
marked this pull request as ready for review
October 22, 2026 00:55
foxnne
enabled auto-merge
October 22, 2026 00:55
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the self-hosted runner work in
docs/AGENT_WORK.md("macOS and Windows provisioning are separate follow-up work", #726). This is the Windows half.What changes
scripts/runner-setup.ps1(PowerShell 5.1+, elevated,-DryRun): same rules asrunner-setup.sh. Private-repo check viagh api, thefizzylabel, Zig version read fromcloud-setup.sh, jj and the Actions runner at pinned or latest releases, deps cache restored into the Zig global cache,FIZZY_BUILD_SLOTS/FIZZY_BUILD_MAX_LOADin the runner.env. The registration token is taken out of the environment at start and goes only intoconfig.cmd's environment; the service password is random, in memory only.fizzy-worker; the runner is installed as a Windows service under it. A service has no desktop, so GUI/window tests cannot run on it. I chose the service because it survives reboots with no stored logon or always-logged-in desktop, and the headless gates need no window. The alternative (auto-logon plus a logon task) is documented and not built until a GUI job exists.scripts/runner-clean.ps1plus a daily taskFizzyRunnerClean: removes untracked.zig-cache/zig-out/zig-pkgunderC:\fizzy\workspacesandactions-runner\_work, vetoed by running zig/zls/Runner.Worker, skips reparse points, requires a tracked-file list. The merged-PR workspace deletion is not ported.scripts/test-runner-setup.ps1+test-runner-setup-windows.sh(skips when pwsh is absent), wired into the lint job inci.yml(GitHub's Ubuntu images have pwsh).docs/AGENT_WORK.md: prerequisites, exact elevated commands, reading the token, verifying Online infizzyedit/work,zig version, onezig build testthrough the runner.Verified
Nothing was run. This session had no pwsh and no Windows, so the PowerShell is only statically reviewed, not parsed. The dry-run test is untested here; its first real run is this PR's CI.
The maintainer must verify on the machine
-DryRunworks in the machine's PowerShell.fizzy, and the service runs asfizzy-worker.zig versionmatchescloud-setup.sh;scripts/zb build testpasses through the runner.tar.exe, andconfig.cmdreading the password fromACTIONS_RUNNER_INPUT_WINDOWSLOGONPASSWORD.Start-ScheduledTask FizzyRunnerClean,LastTaskResult0).scripts/zbunder Git Bash (symlink slots, no load average).Review round 1 (medium review)
Fixed:
C:\fizzyACL (inheritance removed, Modify only on runner/workspaces/zig-cache, tools and bin read-only for the worker, icacls exit codes checked); batch-logon right granted and the task run and its result checked at setup;-ExecutionPolicy Bypasseverywhere and-DryRunno longer needs a gh login; native calls wrapped for Windows PowerShell 5.1 (CI uses pwsh 7 and cannot see that bug class); rerun after a partial registration (clear and--replace); orphaned-SID-safe admin check; sha256 checks for Zig, runner, jj, zstd, deps cache (refuse unverified Zig/runner); long paths, tar failure now fatal unlessFIZZY_RUNNER_DEPS_PARTIAL_OK=1; PATH type preserved, Git bash first in the runner.envPATH, optional Defender exclusion; cleaner dry run creates no lock, links removed individually before deletes.Still unverified: all of it on real Windows/5.1; secedit rights edit, S4U task,
config.cmdenv password,tar.exeon the Linux archive, releasedigestfields (absent means a warning, or refusal for Zig/runner),zbunder Git Bash.Round 3: zstd (no published digest) is pinned to v1.5.7 with its sha256 in the script; Zig (index.json shasum), the Actions runner (asset digest) and jj (asset digest) were checked with gh/curl and do publish digests, so are not pinned.