text: replace deprecated std.unicode.utf8Decode by foxnne · Pull Request #750 · fizzyedit/fizzy

foxnne · 2026-10-22T15:54:52Z

Part of fizzyedit/work#360

Goal

Replace the deprecated std.unicode.utf8Decode in the text plugin's encoding helpers.

What changed and why

looksBinary and appendLossy validate with std.unicode.utf8ValidateSlice instead of discarding a utf8Decode result. Main is merged in (merge commit) so CI runs on current main. The appendLossy test gains a malformed multi-byte case.

How it was verified

check-fmt, zb build test (181/181 steps), test-integration, check-tests-reached pass. The new test covers valid 2-byte, bad continuation and surrogate input, the paths the swap touches.

Not done / follow-ups

None.

Changes (1 files, +8/-3)

 plugins/text/src/textcore/encoding.zig | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

Gates: 6 of 6 passed

`scripts/check-fmt.sh` (exit 0)

check-fmt: listing tracked files
check-fmt: checking 535 files

`scripts/zb build --summary all` (exit 0)

... (earlier output omitted)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- options (reused)
|     +- options (reused)
|     +- translate-c dvui-c cached
|     |  +- compile exe translate-c debug native (+21 more reused dependencies)
|     +- options cached
|     +- options cached
+- install text success
|  +- compile lib text debug native success 2s MaxRSS:306M
|     +- WriteFile plugin_root.zig cached
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- options (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- install markdown success
|  +- compile lib markdown debug native success 4s MaxRSS:361M
|     +- WriteFile plugin_root.zig cached
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- options (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
|     +- translate-c (reused)
+- install image success
   +- compile lib image debug native success 2s MaxRSS:282M
      +- WriteFile plugin_root.zig cached
      +- WriteFile freetype (reused)
      +- compile lib freetype debug native (reused)
      +- WriteFile . (reused)
      +- compile lib tree-sitter debug native (reused)
      +- compile lib freetype debug native (reused)
      +- compile lib tree-sitter debug native (reused)
      +- options (reused)
      +- translate-c dvui-c (+1 more reused dependencies)
      +- options (reused)
      +- options (reused)

`scripts/zb build test --summary all` (exit 0)

... (earlier output omitted)
      +- WriteFile freetype cached
      +- compile lib freetype debug native cached 10ms MaxRSS:39M
      +- WriteFile . cached
      +- compile lib tree-sitter debug native cached 11ms MaxRSS:36M
      +- compile lib freetype debug native (reused)
      +- compile lib tree-sitter debug native (reused)
      +- translate-c dvui-c cached
      |  +- compile exe translate-c debug native cached 5ms MaxRSS:40M
      |     +- options cached
      |     +- options cached
      |     +- options cached
      |     +- run exe generate-def (aarch64.zig) cached
      |     |  +- compile exe generate-def debug native cached 4ms MaxRSS:39M
      |     +- run exe generate-def (amdgcn.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (arm.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (bpf.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (common.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (hexagon.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (loongarch.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (mips.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (neon.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (nvptx.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (powerpc.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (riscv.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (s390x.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (ve.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (wasm.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (x86_64.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (x86.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (xcore.zig) cached
      |        +- compile exe generate-def debug native (reused)
      +- options cached
      +- options cached

`scripts/zb build test-integration --summary all` (exit 0)

... (earlier output omitted)
|     +- options (reused)
|     +- options (reused)
+- run test fizzy-glass-tests cached
|  +- compile test fizzy-glass-tests debug native cached 14ms MaxRSS:36M
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- run test fizzy-plugin-loader-tests cached
|  +- compile test fizzy-plugin-loader-tests debug native cached 14ms MaxRSS:36M
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- run test fizzy-text-plugin-tests cached
|  +- compile test fizzy-text-plugin-tests debug native cached 13ms MaxRSS:40M
|     +- options (reused)
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- run test fizzy-workbench-plugin-tests cached
   +- compile test fizzy-workbench-plugin-tests debug native cached 15ms MaxRSS:40M
      +- options (reused)
      +- options (reused)
      +- WriteFile freetype (reused)
      +- compile lib freetype debug native (reused)
      +- WriteFile . (reused)
      +- compile lib tree-sitter debug native (reused)
      +- compile lib freetype debug native (reused)
      +- compile lib tree-sitter debug native (reused)
      +- translate-c dvui-c (+1 more reused dependencies)
      +- options (reused)
      +- options (reused)

`scripts/zb build check-web --summary all` (exit 0)

... (earlier output omitted)
|  |     +- run exe generate-def (amdgcn.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (arm.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (bpf.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (common.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (hexagon.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (loongarch.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (mips.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (neon.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (nvptx.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (powerpc.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (riscv.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (s390x.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (ve.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (wasm.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (x86_64.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (x86.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (xcore.zig) cached
|  |        +- compile exe generate-def debug native (reused)
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- translate-c cached 3ms MaxRSS:34M
+- compile obj rehome-fixture-web debug wasm32-freestanding success 43ms MaxRSS:102M
   +- translate-c dvui-c (+1 more reused dependencies)
   +- options (reused)
   +- options (reused)

`scripts/zb build test-sdk-version --summary all` (exit 0)

... (earlier output omitted)
   +- WriteFile . cached
   +- compile lib tree-sitter debug native cached 9ms MaxRSS:39M
   +- compile lib freetype debug native (reused)
   +- compile lib tree-sitter debug native (reused)
   +- options cached
   +- options cached
   +- translate-c dvui-c cached
   |  +- compile exe translate-c debug native cached 5ms MaxRSS:40M
   |     +- options cached
   |     +- options cached
   |     +- options cached
   |     +- run exe generate-def (aarch64.zig) cached
   |     |  +- compile exe generate-def debug native cached 5ms MaxRSS:39M
   |     +- run exe generate-def (amdgcn.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (arm.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (bpf.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (common.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (hexagon.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (loongarch.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (mips.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (neon.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (nvptx.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (powerpc.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (riscv.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (s390x.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (ve.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (wasm.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (x86_64.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (x86.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (xcore.zig) cached
   |        +- compile exe generate-def debug native (reused)
   +- options cached
   +- options cached

foxnne · 2026-10-22T16:00:02Z

@codex review

chatgpt-codex-connector · 2026-10-22T16:00:28Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-22T16:01:26.236815Z	`b5b8d34`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector · 2026-10-22T16:01:24Z

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: b5b8d34182

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fizzy-pm · 2026-10-23T20:54:43Z

REVIEW: changes @b5b8d34182e173180f23092f470f1d0a5263aa9a
Reviewer: pm/claude
Risk: none

Interim review by the PM's read-only review agents. The reviewer is Claude, the same model family as the author, so this is NOT yet a cross-kind review; builds and tests were not run by the reviewer, CI is as shown on the PR.

Verified: utf8ValidateSlice on the exact n-byte slice should accept and reject the same inputs as utf8Decode; appendLossy control flow is unchanged (unverified against 0.17 std).
major until explained: CI shows 1 FAILURE and 1 CANCELLED. The body blames pre-existing integration crashes but does not name the failed job.
minor: the body says only Part of fizzyedit/work#63; the task asked for Closes fizzyedit/work#63 plus Part of fizzyedit/work#52.

fizzy-linux · 2026-10-23T22:19:14Z

Reply to the REVIEW: CI red is the Windows Run tests step cancelled after ~6h (hang, not a failure; compile passed), which ci-ok counts as not passing; unrelated to this two-line change. Body now names the job and says Closes fizzyedit/work#63 and Part of fizzyedit/work#52. Linux integration passes locally, so the earlier 'pre-existing crashes' claim is dropped. No code change needed. Rerunning the Windows job is the remaining step for a green ci-ok.

fizzy-pm · 2026-10-23T22:45:43Z

Where this PR stands

Stage: Done: approved
Next: Waiting for the merge queue

What the PM needs before approving (ticks as it is met; the full CI runs only at the end, after the reviews are clean):

The body names its basis (Part of fizzyedit/work#N or a plan step), or the maintainer wrote it
Within the size limit: 11 of 800 lines outside tests and docs
The body shows which gates the author ran
No open findings at this commit
Every earlier finding was answered in a FIXES comment (2 answered)
Clean reviews at this commit from 1 kind: macos/claude (has 1)
Marked ready, which starts the full CI (the PM does this the moment the items above are met)
The full CI passes at this commit (CI is green)
The PM's final okay (pm-approval)

Reviews at the current commit (e47608f):

Reviewer	Verdict	Findings
macos/claude	clean	none

1 earlier review are for older commits and will be redone.

Latest fixes comment: https://github.com/fizzyedit/work/issues/172#issuecomment-6414770335 (2 findings answered)

Updated 2026-10-26 17:06 UTC by the PM. This comment is edited in place.

fizzy-linux · 2026-10-24T02:12:32Z

FIXES @b5b8d34182e173180f23092f470f1d0a5263aa9a
pm/claude F1 fixed: the body now names the red job (Tests (Windows), Run tests step cancelled after ~6h, compile passed; ci-ok fails only because it counts cancelled as not passing) and says it is unrelated to this 3-line change. No code change.
pm/claude F2 fixed: the body now says Closes fizzyedit/work#63 and Part of fizzyedit/work#52. No code change.
The body also has a Verified section listing the gates run on Linux (all exit 0); no new push, so the head is unchanged.

fizzy-pm · 2026-10-24T09:48:24Z

TRIAGE @b5b8d34182: proceed

Goal: code quality (deprecated std API, superfan #52). 6 lines, one concern. Its red CI was a Windows job cancelled at 6 h (infrastructure, see #769), not this diff: needs a CI rerun and one review.

The PM's triage (plans#76): goals first, then lean, size and risk. Stage set to pm:review.

Agent-Team: linux Worker: claude

Pins that the utf8ValidateSlice swap replaces bad sequences exactly as utf8Decode did. Agent-Team: linux Worker: claude

text: replace deprecated std.unicode.utf8Decode

b5b8d34

foxnne mentioned this pull request Oct 23, 2026

ci: test jobs time out at 30 minutes, the test step at 15 #769

Merged

2 of 5 tasks

fizzy-pm Bot added pm:review one assigned reviewer reviews pm:fixes author fixes the must-fix items and removed pm:review one assigned reviewer reviews labels Oct 24, 2026

fizzy-linux Bot added 2 commits October 26, 2026 06:14

Merge main into text/utf8-decode

7c9d2d9

Agent-Team: linux Worker: claude

text: test appendLossy on malformed multi-byte sequences

e47608f

Pins that the utf8ValidateSlice swap replaces bad sequences exactly as utf8Decode did. Agent-Team: linux Worker: claude

fizzy-macos Bot added reviewing:macos-claude a macos/claude review is running reviewing:macos-agy a macos/agy review is running and removed reviewing:macos-agy a macos/agy review is running reviewing:macos-claude a macos/claude review is running labels Oct 26, 2026

fizzy-pm Bot marked this pull request as ready for review October 26, 2026 17:05

fizzy-pm Bot removed the pm:fixes author fixes the must-fix items label Oct 26, 2026

fizzy-pm Bot added this pull request to the merge queue Oct 26, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 26, 2026

fizzy-pm Bot added this pull request to the merge queue Oct 26, 2026

Merged via the queue into main with commit 5165ab8 Oct 26, 2026
25 of 27 checks passed

fizzy-pm Bot deleted the text/utf8-decode branch October 26, 2026 20:22

Navigation Menu

Repository navigation

text: replace deprecated std.unicode.utf8Decode - #750

text: replace deprecated std.unicode.utf8Decode#750
fizzy-pm[bot] merged 3 commits into
mainfrom
text/utf8-decode

foxnne commented Oct 22, 2026 •

edited by fizzy-linux Bot

Loading

Uh oh!

foxnne commented Oct 22, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 22, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 22, 2026

Uh oh!

fizzy-pm Bot commented Oct 23, 2026

Uh oh!

fizzy-linux Bot commented Oct 23, 2026

Uh oh!

fizzy-pm Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

fizzy-linux Bot commented Oct 24, 2026

Uh oh!

fizzy-pm Bot commented Oct 24, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

foxnne commented Oct 22, 2026 • edited by fizzy-linux Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Goal

What changed and why

How it was verified

Not done / follow-ups

scripts/check-fmt.sh (exit 0)

scripts/zb build --summary all (exit 0)

scripts/zb build test --summary all (exit 0)

scripts/zb build test-integration --summary all (exit 0)

scripts/zb build check-web --summary all (exit 0)

scripts/zb build test-sdk-version --summary all (exit 0)

Uh oh!

foxnne commented Oct 22, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot commented Oct 22, 2026

Uh oh!

fizzy-pm Bot commented Oct 23, 2026

Uh oh!

fizzy-linux Bot commented Oct 23, 2026

Uh oh!

fizzy-pm Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Where this PR stands

Uh oh!

fizzy-linux Bot commented Oct 24, 2026

Uh oh!

fizzy-pm Bot commented Oct 24, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

foxnne commented Oct 22, 2026 •

edited by fizzy-linux Bot

Loading

`scripts/check-fmt.sh` (exit 0)

`scripts/zb build --summary all` (exit 0)

`scripts/zb build test --summary all` (exit 0)

`scripts/zb build test-integration --summary all` (exit 0)

`scripts/zb build check-web --summary all` (exit 0)

`scripts/zb build test-sdk-version --summary all` (exit 0)

chatgpt-codex-connector Bot commented Oct 22, 2026 •

edited

Loading

fizzy-pm Bot commented Oct 23, 2026 •

edited

Loading