Repository navigation
ci: web-qa-builds - #818
fizzy-linux[bot] wants to merge 3 commits into
Conversation
…iews web.yml builds fizzyed.it/testapp/debug/ from main on every push: Debug, -Dapp-registry-url the store test catalog, storage fizzy-testapp-debug. web-pr.yml builds fizzyed.it/testapp/pr-N/ only for same-repo PRs labelled qa:needed (on label, and on push while labelled), tells the PR's private thread, and removes the release when the PR closes or loses the label. Part of fizzyedit/work#188 Agent-Team: linux Worker: claude Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
PM note: how this PR will be handledWhat it is for: ci: web-qa-builds Rules that apply: touches CI or workflows. Things to watch (checked by rule):
What happens next:
A living status comment below is kept current. Nothing here is a merge decision. |
Where this PR standsStage: Author's turn What the PM needs before approving (ticks as it is met; the full CI runs only at the end, after the reviews are clean):
Rules that apply: touches CI or workflows. Reviews at the current commit (
4 earlier reviews are for older commits and will be redone. Latest fixes comment: https://github.com/fizzyedit/work/issues/204#issuecomment-6421155561 (0 findings answered) Updated 2026-10-26 21:44 UTC by the PM. This comment is edited in place. |
Move the concurrency group from the workflow onto the build, publish and remove jobs, so a label event that skips them cannot cancel a build in flight. publish runs only on success; remove also runs when the build fails, so a stale preview is not left under the PR's URL. Agent-Team: linux Worker: claude Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
OPS: released reviewing:windows-agy — Windows reviews are paused until Windows gates run (work#220/#254); another reviewer can take this PR. |
Agent-Team: linux Worker: claude Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Part of fizzyedit/work#188
Goal
PR previews for
qa:neededPRs on a separate origin, safely: no stale overwrite, secrets split by job, no fork code.What changed and why
pr-N-fizzy-previews.fizzyedit.workers.dev), a separate origin from fizzyed.it;WEBSITE_DISPATCH_TOKENis no longer used by previews.buildcancels per push (group-build);publish/removequeue in a-deploygroup, never cancel, and publish checks the PR is still open, labelled and at the built head before deploying.removealso runs after a failed publish, but not when a newer push owns the preview.WORK_THREAD_TOKENis only in the newcommentjob; Cloudflare secrets only inpublish/remove, which unzip the build and never run it. Same-repo andqa:neededonly; per-PR storage name kept.web.ymlcomment now says what exists (optimize_classes is step d, not landed).How it was verified
Workflow-only: check-fmt passes, YAML parses. The lifecycle has not been run (needs the Cloudflare secrets and a labelled test PR).
Not done / follow-ups
🤖 Generated with Claude Code