Skip to content

ci: web-qa-builds - #818

Draft
fizzy-linux[bot] wants to merge 3 commits into
mainfrom
ci/web-qa-builds
Draft

fizzy-linux[bot] wants to merge 3 commits into
mainfrom
ci/web-qa-builds

Conversation

@fizzy-linux

@fizzy-linux fizzy-linux Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Part of fizzyedit/work#188

Goal

PR previews for qa:needed PRs on a separate origin, safely: no stale overwrite, secrets split by job, no fork code.

What changed and why

  • Previews deploy as Cloudflare Workers previews (pr-N-fizzy-previews.fizzyedit.workers.dev), a separate origin from fizzyed.it; WEBSITE_DISPATCH_TOKEN is no longer used by previews.
  • build cancels per push (group -build); publish/remove queue in a -deploy group, never cancel, and publish checks the PR is still open, labelled and at the built head before deploying.
  • remove also runs after a failed publish, but not when a newer push owns the preview.
  • WORK_THREAD_TOKEN is only in the new comment job; Cloudflare secrets only in publish/remove, which unzip the build and never run it. Same-repo and qa:needed only; per-PR storage name kept.
  • The web.yml comment now says what exists (optimize_classes is step d, not landed).

How it was verified

Workflow-only: check-fmt passes, YAML parses. The lifecycle has not been run (needs the Cloudflare secrets and a labelled test PR).

Not done / follow-ups

  • Lifecycle run links (ruling item 2) after the secrets exist.
  • wrangler preview flags unverified here; budget of 8 previews and orphan sweep.

🤖 Generated with Claude Code

…iews

web.yml builds fizzyed.it/testapp/debug/ from main on every push: Debug,
-Dapp-registry-url the store test catalog, storage fizzy-testapp-debug.
web-pr.yml builds fizzyed.it/testapp/pr-N/ only for same-repo PRs labelled
qa:needed (on label, and on push while labelled), tells the PR's private
thread, and removes the release when the PR closes or loses the label.

Part of fizzyedit/work#188

Agent-Team: linux
Worker: claude
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@fizzy-pm

fizzy-pm Bot commented Oct 24, 2026

Copy link
Copy Markdown

PM note: how this PR will be handled

What it is for: ci: web-qa-builds
Issue #188: web: a Debug testapp that loads plugins from a store test channel, and PR previews for qa:needed PRs
Done when (from the issue): draft PR; the debug testapp loads with every plugin; a labelled test PR gets a preview and loses it on close.

Rules that apply: touches CI or workflows.
Reviews needed: 2, from two different kinds.
Needs the maintainer's explicit yes before merge: yes

Things to watch (checked by rule):

  • the body names its work issue (Part of fizzyedit/work#N)
  • size within 800 lines outside tests and docs (181)
  • a gates section with what was run

What happens next:

  1. Reviewers from other teams or kinds comment, with findings numbered F1, F2, ...
  2. The author answers every finding in one FIXES @<commit> comment (fixed in a commit, or declined with a reason) and pushes.
  3. Reviewers re-review the new commit on their own.
  4. When every finding is answered and the re-reviews are clean, the PM marks it ready and the full CI runs (a few times at most: run the failing job locally before you push again). Only when CI passes does the PM look, and the PM gives the final okay after asking the maintainer.

A living status comment below is kept current. Nothing here is a merge decision.

@fizzy-pm

fizzy-pm Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Where this PR stands

Stage: Author's turn
Next: Author should add the gates you ran, and their result, to the body

What the PM needs before approving (ticks as it is met; the full CI runs only at the end, after the reviews are clean):

  • The body names its basis (Part of fizzyedit/work#N or a plan step)
  • Within the size limit: 247 of 800 lines outside tests and docs
  • The body shows which gates the author ran
  • No open findings at this commit (6 open)
  • Every earlier finding was answered in a FIXES comment (0 answered)
  • Clean reviews at this commit from 2 different kinds: none yet (has 0)
  • Marked ready, which starts the full CI (the PM does this the moment the items above are met)
  • The full CI passes at this commit
  • The maintainer's explicit yes (ci)
  • The PM's final okay (pm-approval)

Rules that apply: touches CI or workflows.

Reviews at the current commit (6a215a4):

Reviewer Verdict Findings
linux/agy changes 3
linux/codex changes 3

4 earlier reviews are for older commits and will be redone.

Latest fixes comment: https://github.com/fizzyedit/work/issues/204#issuecomment-6421155561 (0 findings answered)

Updated 2026-10-26 21:44 UTC by the PM. This comment is edited in place.

@fizzy-pm fizzy-pm Bot added pm:review one assigned reviewer reviews reviewer:macos-codex the PM assigned macos/codex to review this PR labels Oct 24, 2026
@fizzy-linux fizzy-linux Bot added the reviewing:linux-agy a linux/agy review is running label Oct 24, 2026
@fizzy-macos fizzy-macos Bot added reviewing:macos-agy a macos/agy review is running and removed reviewing:macos-agy a macos/agy review is running labels Oct 24, 2026
@fizzy-linux fizzy-linux Bot added reviewing:linux-codex a linux/codex review is running and removed reviewing:linux-agy a linux/agy review is running labels Oct 24, 2026
@fizzy-macos fizzy-macos Bot added the reviewing:macos-claude a macos/claude review is running label Oct 24, 2026
@fizzy-linux fizzy-linux Bot removed the reviewing:linux-codex a linux/codex review is running label Oct 24, 2026
@fizzy-macos fizzy-macos Bot added reviewing:macos-codex a macos/codex review is running and removed reviewing:macos-claude a macos/claude review is running reviewing:macos-codex a macos/codex review is running labels Oct 24, 2026
@fizzy-pm fizzy-pm Bot added pm:fixes author fixes the must-fix items and removed pm:review one assigned reviewer reviews labels Oct 24, 2026
Move the concurrency group from the workflow onto the build, publish and
remove jobs, so a label event that skips them cannot cancel a build in
flight. publish runs only on success; remove also runs when the build
fails, so a stale preview is not left under the PR's URL.

Agent-Team: linux
Worker: claude

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@fizzy-linux fizzy-linux Bot added the reviewing:linux-codex a linux/codex review is running label Oct 24, 2026
@fizzy-macos fizzy-macos Bot added reviewing:macos-codex a macos/codex review is running reviewing:macos-agy a macos/agy review is running reviewing:macos-claude a macos/claude review is running and removed reviewing:macos-agy a macos/agy review is running reviewing:macos-codex a macos/codex review is running reviewing:macos-claude a macos/claude review is running labels Oct 24, 2026
@fizzy-linux fizzy-linux Bot removed the reviewing:linux-codex a linux/codex review is running label Oct 24, 2026
@fizzy-macos fizzy-macos Bot added the reviewing:macos-agy a macos/agy review is running label Oct 24, 2026
@fizzy-macos fizzy-macos Bot removed reviewing:macos-codex a macos/codex review is running reviewing:macos-agy a macos/agy review is running labels Oct 24, 2026
@fizzy-windows fizzy-windows Bot added the reviewing:windows-agy a windows/agy review is running label Oct 24, 2026
@fizzy-ops fizzy-ops Bot removed the reviewing:windows-agy a windows/agy review is running label Oct 24, 2026
@fizzy-ops

fizzy-ops Bot commented Oct 24, 2026

Copy link
Copy Markdown

OPS: released reviewing:windows-agy — Windows reviews are paused until Windows gates run (work#220/#254); another reviewer can take this PR.

@fizzy-macos fizzy-macos Bot added the reviewing:macos-claude a macos/claude review is running label Oct 24, 2026
@fizzy-pm fizzy-pm Bot added pm:verify the same reviewer verifies the fixes and removed pm:fixes author fixes the must-fix items labels Oct 24, 2026
@fizzy-macos fizzy-macos Bot added reviewing:macos-codex a macos/codex review is running and removed reviewing:macos-claude a macos/claude review is running reviewing:macos-codex a macos/codex review is running labels Oct 24, 2026
@fizzy-pm fizzy-pm Bot added reviewer:linux-codex the PM assigned linux/codex to review this PR and removed reviewer:macos-codex the PM assigned macos/codex to review this PR pm:verify the same reviewer verifies the fixes reviewer:linux-codex the PM assigned linux/codex to review this PR labels Oct 24, 2026
Agent-Team: linux
Worker: claude

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@fizzy-linux fizzy-linux Bot added reviewing:linux-codex a linux/codex review is running reviewing:linux-agy a linux/agy review is running and removed reviewing:linux-codex a linux/codex review is running reviewing:linux-agy a linux/agy review is running labels Oct 26, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants