Repository navigation
automation: demos-ledger - #836
Conversation
A demo plays among the person's panes and documents instead of cutting them away. Targets are found by role, a new `skip` op leaves out the steps whose target is already shown (the explorer already open), and tape format 4 carries it. Workbench's holdPanes machinery and the Demo stage's reset-to-one-pane are gone; a seek restores the arrangement its keyframe was entered with. PR 2 of 5 for fizzyedit/work#137. Agent-Team: linux Worker: claude Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…opened Demo.end reloads the saved layout again (end only, never keep), so a tour played to the end leaves no splits, floats or explorer in the person's window and saves none. ownsDocument no longer counts every document missing from the begin list as the demo's: a file the person had open or was opening at begin stays theirs even when its handle arrives later. The phone tour test keeps the person's tabs. Agent-Team: linux Worker: claude Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…utomation/demos-ledger
…s are not saved Ownership is positive: a document is the demo's when it is one of its `demo://` files, so a file the person opens while it plays is theirs. The workbench writes no `panes.zzon` while a demo plays (`panes_held`), and the end of the tape puts the panes back as noted at `begin`. The tour's explorer choice reads the explorer's place after a `waitIdle`, and a phone puts away the sheet the demo brought up (`skipIfGone`). Part of fizzyedit/work#137. Agent-Team: linux Worker: claude Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
PM note: how this PR will be handledWhat it is for: automation: demos-ledger Rules that apply: touches the SDK or plugin ABI: the shape fingerprint must be recorded. Things to watch (checked by rule):
What happens next:
A living status comment below is kept current. Nothing here is a merge decision. |
Where this PR standsStage: In review What the PM needs before approving (ticks as it is met; the full CI runs only at the end, after the reviews are clean):
Rules that apply: touches the SDK or plugin ABI: the shape fingerprint must be recorded. Reviews at the current commit (
5 earlier reviews are for older commits and will be redone. Latest fixes comment: https://github.com/fizzyedit/work/issues/307#issuecomment-6396977010 (0 findings answered) Updated 2026-10-25 12:52 UTC by the PM. This comment is edited in place. |
Agent-Team: linux Worker: claude Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Conflicts in src/editor/Demo.zig and tests/integration.zig resolved keeping both sides. Agent-Team: windows Worker: claude
…o split With the person's layout kept (explorer open), the pane is 944x473 and core.placement answers "card", so drop:beside is never drawn and the tour timed out. The workbench now marks workbench.beside-room while a split would happen; the tour drops on the edge then, and brings the tab forward otherwise. The tour tests shut the explorer so the split runs. Agent-Team: linux Worker: claude Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
PM: re-enqueued at 32acc70. The queue ejection (run 40196885060) was Tests (Windows) timing out after 15 minutes, the known Windows test hang (work#253); the same change passed Tests (Windows) in the queue run before it (40195193776). The approval stands. |
Part of fizzyedit/work#320
Goal
Part of work#137: demos play in the person's own layout and own only what they opened. This round fixes the Linux Integration failures after merging main.
What changed and why
Main's placement service answers "card" for rooms where a split's halves are under 480x360. Now that a demo no longer closes the explorer, the person's pane in the 1280x800 test window is 944x473, so
drop:besidewas never drawn: the tour timed out (1 timeout) and the headless test crashed. The workbench marksworkbench.beside-roomon the person's pane when a split would happen; the tour drops on the edge then and clicks the tab forward otherwise (skipIfGone/skipIfShown). The two tour tests shut the explorer first so the split runs.How it was verified
Reproduced both failures on this branch before the change; after it, scripts/zb build test-integration 94/94, test 181/181, lint, check-web, check-fmt and check-tests-reached pass on Linux. The SDK shape fingerprint did not move (nothing under sdk/src changed).
Not done / follow-ups
Graceful ledger cleanup and the phone tab strip (work#313) stay follow-ups, as ruled.
Changes (17 files, +447/-639)
Gates: 6 of 6 passed
scripts/check-fmt.sh(exit 0)scripts/zb build --summary all(exit 0)scripts/zb build test --summary all(exit 0)scripts/zb build test-integration --summary all(exit 0)scripts/zb build check-web --summary all(exit 0)scripts/zb build test-sdk-version --summary all(exit 0)