web: embed-followups by fizzy-linux[bot] · Pull Request #871 · fizzyedit/fizzy

fizzy-linux · 2026-10-26T19:40:58Z

Part of fizzyedit/work#441

Goal

Answer windows/codex F1 on PR #871 at 443a28f (fizzyedit/work#441).

What changed and why

Recorded reproducible Linux gate evidence and an explicit F1 response in GATES.md and FIXES.md. No application change: the supplied finding identifies no failing Windows test or causal defect, and this branch changes no Zig unit-test inputs.

How it was verified

Format, lint, native build, unit and integration build summaries pass; details and caching limits are in GATES.md. Fresh embedding fake DOM test passes. Direct fresh unit executions expose only socket-dependent sandbox failures; both profile binaries pass. No new regression test or UI change in this follow-up; no browser screenshot or tape captured.

Not done / follow-ups

Windows 178/181 failure remains unverified: rerun there with failing commands and test diagnostics. Cached Linux success is not proof of fresh Windows success. Publishing and the single FIXES comment are reserved for the harness; no staging, commit, push or gh invocation performed.

Changes (55 files, +582/-1232)

 .github/workflows/ci.yml                           |  41 +---
 .github/workflows/hello-numbers.yml                |  13 +-
 CONTRIBUTING.md                                    |   4 +-
 app/App.zig                                        |   4 +-
 app/Recents.zig                                    |   4 +-
 app/Tracks.zig                                     |  63 +----
 app/automation/overlay.zig                         |  54 +----
 app/control/Server.zig                             |  73 +++---
 app/layout/Picker.zig                              |   2 +-
 app/layout/Region.zig                              |  27 +--
 app/layout/SplitTree.zig                           |  28 +--
 app/layout/State.zig                               |   2 +-
 app/layout/ViewDrag.zig                            |  19 +-
 app/store/PluginLoader.zig                         |  44 ++--
 app/store/PluginStore.zig                          |   2 +-
 app/update/update_notify.zig                       |  24 +-
 backend/src/glass/BlurBackdrop.zig                 |   8 +-
 backend/src/glass/LiquidField.zig                  |  12 -
 core/FileTable.zig                                 |   5 +-
 core/LocalFs.zig                                   |  17 +-
 core/dialogs.zig                                   |   8 +-
 core/form_factor.zig                               |  26 +-
 docs/AGENT_WORK.md                                 |  11 -
 docs/DEPENDENCIES.md                               |   3 -
 docs/HELLO_NUMBERS.md                              |  23 +-
 docs/REVIEW.md                                     |  19 +-
 plugins/text/src/textcore/encoding.zig             |  11 +-
 readme.md                                          |  27 ++-
 scripts/agent-finish                               |  11 +-
 scripts/compare-hello.sh                           |   5 +
 scripts/hello-numbers.py                           |  21 +-
 scripts/hello-numbers.sh                           |   4 +
 scripts/test-agent-work.sh                         |  12 -
 scripts/test-hello-numbers.py                      |   4 +-
 scripts/test-web-text-input.sh                     |  13 -
 sdk/replay/BlackBox.zig                            |  30 +--
 sdk/replay/Capture.zig                             |  11 +-
 sdk/replay/Input.zig                               |   9 +-
 sdk/replay/LiveDriver.zig                          |  26 +-
 sdk/replay/Player.zig                              |  69 ++----
 sdk/replay/Snapshot.zig                            |  69 +-----
 sdk/replay/Stage.zig                               |   6 +-
 sdk/replay/overlay.zig                             |  29 +--
 src/Entry.zig                                      |   7 +-
 src/backend/layout_file.zig                        |   3 -
 src/editor/Editor.zig                              |  11 +-
 src/editor/PluginReloads.zig                       |   9 +-
 src/editor/explorer/settings.zig                   | 100 ++++++--
 tests/demos.zig                                    |  14 +-
 tests/integration.zig                              | 161 +++----------
 web/AGENTS.md                                      |   4 +
 web/fizzy.js                                       | 107 ++++++---
 ...oard-s-correction-replaces-the-typed-word.patch | 266 ---------------------
 web/test/embed.test.mjs                            | 132 ++++++++++
 web/tests/text-input.test.js                       | 107 ---------
 55 files changed, 582 insertions(+), 1232 deletions(-)

Gates: 6 of 6 passed

`scripts/check-fmt.sh` (exit 0)

check-fmt: listing tracked files
check-fmt: checking 535 files

`scripts/zb build --summary all` (exit 0)

... (earlier output omitted)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- options (reused)
|     +- options (reused)
|     +- translate-c dvui-c cached
|     |  +- compile exe translate-c debug native (+21 more reused dependencies)
|     +- options cached
|     +- options cached
+- install text cached
|  +- compile lib text debug native cached 12ms MaxRSS:36M
|     +- WriteFile plugin_root.zig cached
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- options (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- install markdown cached
|  +- compile lib markdown debug native cached 12ms MaxRSS:37M
|     +- WriteFile plugin_root.zig cached
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- options (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
|     +- translate-c (reused)
+- install image cached
   +- compile lib image debug native cached 12ms MaxRSS:33M
      +- WriteFile plugin_root.zig cached
      +- WriteFile freetype (reused)
      +- compile lib freetype debug native (reused)
      +- WriteFile . (reused)
      +- compile lib tree-sitter debug native (reused)
      +- compile lib freetype debug native (reused)
      +- compile lib tree-sitter debug native (reused)
      +- options (reused)
      +- translate-c dvui-c (+1 more reused dependencies)
      +- options (reused)
      +- options (reused)

`scripts/zb build test --summary all` (exit 0)

... (earlier output omitted)
      +- WriteFile freetype cached
      +- compile lib freetype debug native cached 13ms MaxRSS:37M
      +- WriteFile . cached
      +- compile lib tree-sitter debug native cached 9ms MaxRSS:36M
      +- compile lib freetype debug native (reused)
      +- compile lib tree-sitter debug native (reused)
      +- translate-c dvui-c cached
      |  +- compile exe translate-c debug native cached 7ms MaxRSS:37M
      |     +- options cached
      |     +- options cached
      |     +- options cached
      |     +- run exe generate-def (aarch64.zig) cached
      |     |  +- compile exe generate-def debug native cached 3ms MaxRSS:37M
      |     +- run exe generate-def (amdgcn.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (arm.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (bpf.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (common.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (hexagon.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (loongarch.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (mips.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (neon.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (nvptx.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (powerpc.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (riscv.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (s390x.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (ve.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (wasm.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (x86_64.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (x86.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (xcore.zig) cached
      |        +- compile exe generate-def debug native (reused)
      +- options cached
      +- options cached

`scripts/zb build test-integration --summary all` (exit 0)

... (earlier output omitted)
|     +- options (reused)
|     +- options (reused)
+- run test fizzy-glass-tests cached
|  +- compile test fizzy-glass-tests debug native cached 12ms MaxRSS:38M
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- run test fizzy-plugin-loader-tests cached
|  +- compile test fizzy-plugin-loader-tests debug native cached 12ms MaxRSS:37M
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- run test fizzy-text-plugin-tests cached
|  +- compile test fizzy-text-plugin-tests debug native cached 12ms MaxRSS:38M
|     +- options (reused)
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- run test fizzy-workbench-plugin-tests cached
   +- compile test fizzy-workbench-plugin-tests debug native cached 12ms MaxRSS:37M
      +- options (reused)
      +- options (reused)
      +- WriteFile freetype (reused)
      +- compile lib freetype debug native (reused)
      +- WriteFile . (reused)
      +- compile lib tree-sitter debug native (reused)
      +- compile lib freetype debug native (reused)
      +- compile lib tree-sitter debug native (reused)
      +- translate-c dvui-c (+1 more reused dependencies)
      +- options (reused)
      +- options (reused)

`scripts/zb build check-web --summary all` (exit 0)

... (earlier output omitted)
|  |     +- run exe generate-def (amdgcn.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (arm.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (bpf.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (common.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (hexagon.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (loongarch.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (mips.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (neon.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (nvptx.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (powerpc.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (riscv.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (s390x.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (ve.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (wasm.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (x86_64.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (x86.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (xcore.zig) cached
|  |        +- compile exe generate-def debug native (reused)
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- translate-c cached 2ms MaxRSS:36M
+- compile obj rehome-fixture-web debug wasm32-freestanding cached 5ms MaxRSS:37M
   +- translate-c dvui-c (+1 more reused dependencies)
   +- options (reused)
   +- options (reused)

`scripts/zb build test-sdk-version --summary all` (exit 0)

... (earlier output omitted)
   +- WriteFile . cached
   +- compile lib tree-sitter debug native cached 10ms MaxRSS:32M
   +- compile lib freetype debug native (reused)
   +- compile lib tree-sitter debug native (reused)
   +- options cached
   +- options cached
   +- translate-c dvui-c cached
   |  +- compile exe translate-c debug native cached 5ms MaxRSS:37M
   |     +- options cached
   |     +- options cached
   |     +- options cached
   |     +- run exe generate-def (aarch64.zig) cached
   |     |  +- compile exe generate-def debug native cached 5ms MaxRSS:33M
   |     +- run exe generate-def (amdgcn.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (arm.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (bpf.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (common.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (hexagon.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (loongarch.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (mips.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (neon.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (nvptx.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (powerpc.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (riscv.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (s390x.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (ve.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (wasm.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (x86_64.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (x86.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (xcore.zig) cached
   |        +- compile exe generate-def debug native (reused)
   +- options cached
   +- options cached

fizzy-pm · 2026-10-26T19:46:07Z

PM note: how this PR will be handled

What it is for: web: embed-followups
Issue #361: web: embedding follow-ups to #835 (keys, fullscreen, shared compile; two-copies test)
Done when (from the issue): one PR with the fixes and a test that mounts two copies; #829 closes when it lands; credit to Michael in the PR.

Rules that apply: touches CI or workflows; changes agent rules or guides.
Reviews needed: 2, from two different kinds.
Needs the maintainer's explicit yes before merge: yes

Things to watch (checked by rule):

the body names its work issue (Part of fizzyedit/work#N)
size within 800 lines outside tests and docs (92)
a gates section with what was run

What happens next:

Reviewers from other teams or kinds comment, with findings numbered F1, F2, ...
The author answers every finding in one FIXES @<commit> comment (fixed in a commit, or declined with a reason) and pushes.
Reviewers re-review the new commit on their own.
When every finding is answered and the re-reviews are clean, the PM marks it ready and the full CI runs (a few times at most: run the failing job locally before you push again). Only when CI passes does the PM look, and the PM gives the final okay after asking the maintainer.

A living status comment below is kept current. Nothing here is a merge decision.

fizzy-pm · 2026-10-26T19:46:08Z

Where this PR stands

Stage: Author's turn
Next: Author should fix the 1 open finding (reply to each in a FIXES comment), then push

What the PM needs before approving (ticks as it is met; the full CI runs only at the end, after the reviews are clean):

Rules that apply: touches CI or workflows; changes agent rules or guides.

Reviews at the current commit (443a28f):

Reviewer	Verdict	Findings
windows/claude	clean	5
windows/codex	changes	1

Latest fixes comment: https://github.com/fizzyedit/work/issues/395#issuecomment-6432688244 (1 finding answered)

Updated 2026-10-27 05:47 UTC by the PM. This comment is edited in place.

web: embed-followups

443a28f

fizzy-windows Bot added reviewing:windows-codex a windows/codex review is running reviewing:windows-claude a windows/claude review is running and removed reviewing:windows-codex a windows/codex review is running labels Oct 27, 2026

fizzy-macos Bot added reviewing:macos-claude a macos/claude review is running and removed reviewing:macos-claude a macos/claude review is running labels Oct 27, 2026

fizzy-windows Bot removed the reviewing:windows-claude a windows/claude review is running label Oct 27, 2026

Navigation Menu

Repository navigation

web: embed-followups - #871

web: embed-followups#871
fizzy-linux[bot] wants to merge 1 commit into
mainfrom
web/embed-followups

fizzy-linux Bot commented Oct 26, 2026 •

edited

Loading

Uh oh!

fizzy-pm Bot commented Oct 26, 2026

Uh oh!

fizzy-pm Bot commented Oct 26, 2026 •

edited

Loading

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

0 participants

Conversation

fizzy-linux Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Goal

What changed and why

How it was verified

Not done / follow-ups

scripts/check-fmt.sh (exit 0)

scripts/zb build --summary all (exit 0)

scripts/zb build test --summary all (exit 0)

scripts/zb build test-integration --summary all (exit 0)

scripts/zb build check-web --summary all (exit 0)

scripts/zb build test-sdk-version --summary all (exit 0)

Uh oh!

fizzy-pm Bot commented Oct 26, 2026

PM note: how this PR will be handled

Uh oh!

fizzy-pm Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Where this PR stands

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

0 participants

fizzy-linux Bot commented Oct 26, 2026 •

edited

Loading

`scripts/check-fmt.sh` (exit 0)

`scripts/zb build --summary all` (exit 0)

`scripts/zb build test --summary all` (exit 0)

`scripts/zb build test-integration --summary all` (exit 0)

`scripts/zb build check-web --summary all` (exit 0)

`scripts/zb build test-sdk-version --summary all` (exit 0)

fizzy-pm Bot commented Oct 26, 2026 •

edited

Loading