Repository navigation
build: api-fixture-tests - #879
Conversation
A fixture app builds two staticModule plugin packages (both kinds of executable, and native-only), the web and package steps, and the duplicate-plugin and taken-web-step errors against this tree. Agent-Team: linux Worker: claude Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
PM note: how this PR will be handledWhat it is for: build: api-fixture-tests Rules that apply: none special. Things to watch (checked by rule):
What happens next:
A living status comment below is kept current. Nothing here is a merge decision. |
Where this PR standsStage: Done: approved What the PM needs before approving (ticks as it is met; the full CI runs only at the end, after the reviews are clean):
Reviews at the current commit (
4 earlier reviews are for older commits and will be redone. Latest fixes comment: https://github.com/fizzyedit/work/issues/406#issuecomment-6434578004 (0 findings answered) Updated 2026-10-27 07:34 UTC by the PM. This comment is edited in place. |
The fixture app now reads fixture-helper.txt from the pack input, and the plugin package links a C source it calls at register, so a lost package-dirs staging or a lost dependency fails check-examples. Agent-Team: linux Worker: claude Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Agent-Team: linux Worker: codex
Agent-Team: linux Worker: codex
Resolved scripts/check-examples.sh: kept main's #860 app-only fixture and the PR's fixture-only mode (EXAMPLES_BUILDS) plus the build API fixture block. Agent-Team: linux Worker: claude
Part of fizzyedit/work#422
Rework: work#455
Goal
Reconcile PR #879 with main at 2f68419 for fizzyedit/work#455 (part of work#422).
What changed and why
Applied main's changes to the working tree and resolved scripts/check-examples.sh by retaining the external-example preparation/build guard for EXAMPLES_BUILDS="" and running main's #860 app-only missing-workbench rejection outside that guard. The PR's build API fixture assertions remain intact.
How it was verified
Formatting, lint, native build, web compilation and SDK fingerprint checks passed. The fixture-only runner verifies the missing-workbench rejection plus C-backed native linking, native-only exclusion from wasm, web installation and duplicate API rejection. See GATES.md for final results and named socket tests denied by the sandbox. No UI changes were authored.
Not done / follow-ups
The harness must record the merge ancestry (HEAD 781ae56 plus main 2f68419), commit, push and post the FIXES comment; Git metadata is read-only to this worker. Full Linux/Windows/macOS CI and ci-ok need the harness. Packaging assertions require dotnet; external example repositories require network or supplied checkouts. Historical macOS integration failure needs a macOS rerun with full diagnostics.
Changes (9 files, +258/-26)
Gates: 6 of 6 passed
scripts/check-fmt.sh(exit 0)scripts/zb build --summary all(exit 0)scripts/zb build test --summary all(exit 0)scripts/zb build test-integration --summary all(exit 0)scripts/zb build check-web --summary all(exit 0)scripts/zb build test-sdk-version --summary all(exit 0)