Repository navigation
core: Rearrange, the pure keyed set behind layout-to-layout motion (R1) - #997
fizzy-linux[bot] wants to merge 2 commits into
Conversation
Agent-Team: linux Worker: codex
|
TRIAGE @b51ed7dd auto: mechanical rules met (fizzy-* app author, names work#637, 36 non-test lines <= 400, no risky path). Labelled |
PM note: how this PR will be handledWhat it is for: linux: work-637 Rules that apply: none special. Things to watch (checked by rule):
What happens next:
A living status comment below is kept current. Nothing here is a merge decision. |
Where this PR standsStage: Author's turn What the PM needs before approving (ticks as it is met; the full CI runs only at the end, after the reviews are clean):
Reviews at the current commit (
2 earlier reviews are for older commits and will be redone. Latest fixes comment: https://github.com/fizzyedit/work/issues/700#issuecomment-6496192896 (3 findings answered) Updated 2026-10-29 13:19 UTC by the PM. This comment is edited in place. |
Agent-Team: linux Worker: codex
|
Closed by the PM (2026-10-30): this work already merged in another PR (named in its work thread), so this one is superseded. No change needed from the author. |
Part of fizzyedit/work#637
Rework: work#707
In plain words
This adds stronger checks that items keep moving smoothly while a newly added item is measured. The checks cover both position and size, and confirm movement changes destination once measurement finishes.
What you will notice
Nothing visible: internal test coverage only.
How this serves fizzy
Principle: evidence over opinion (VISION 7); adds evidence that the measurement hold preserves smooth movement across position and size.
Goal
PR title: core: test the rearrange measurement hold on all rect lanes
Address PM RULING items 1 and 2 for PR #997. Part of fizzyedit/work#707; test-only follow-up to work#637.
What changed and why
Fold the duplicate rectangle-lane test into the existing measurement-hold test. Assert x/y/w/h while moving, the complete held target, and the pending target taking effect after measurement. Production code is unchanged.
How it was verified
All 16 standalone rearrange tests pass. Disabling the measurement hold in a scratch copy makes the consolidated test fail. Gate results are recorded in GATES.md; cached steps are included in the build summaries.
Not done / follow-ups
The harness must set the PR title to the exact title above, publish this revised description, and post one FIXES comment on work#700 using FIXES.md and the resulting commit. This sandbox has no network or publishing credentials; no commits, pushes, ready marking, or merge performed.
Changes (9 files, +19/-301)
Gates: not run yet
Gates not run yet;
scripts/agent-finish 707replaces this with their output.