Skip to content

readme: Don't specify setting cache key to github.sha - #261

Merged
bbhtt merged 2 commits into
masterfrom
bbhtt/fix-cache-keydoc
Aug 25, 2026
Merged

readme: Don't specify setting cache key to github.sha#261
bbhtt merged 2 commits into
masterfrom
bbhtt/fix-cache-keydoc

Conversation

@bbhtt

@bbhtt bbhtt commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

It changes with every commit so nothing will get restored ever. The current default of not specifying cache-key is already good enough to restore things in most cases. The example in the readme is misleading.

Closes: #239

It changes with every commit so nothing will get restored ever. The
current default of not specifying cache-key is already good enough
to restore things in most cases. The example in the readme is
misleading.

Closes: #239
@bbhtt

bbhtt commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator Author

Merging #263 might fix the CI issue. There's probably some caching or network issue that's causing the older runtime download to fail.

@bbhtt

bbhtt commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator Author

ah looks like all fell down, i'll retry after a while and merge if it's ok.

@bbhtt
bbhtt merged commit 09e3d61 into master Aug 25, 2026
45 of 81 checks passed
@bbhtt
bbhtt deleted the bbhtt/fix-cache-keydoc branch August 25, 2026 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using github.sha in cache-key prevents cache from being restored (README example)

2 participants