feat(drivers): add card view layout for Drivers Management - #299
Open
janni1288 wants to merge 8 commits into
Open
feat(drivers): add card view layout for Drivers Management#299janni1288 wants to merge 8 commits into
janni1288 wants to merge 8 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-v0.6.61 #299 +/- ##
===============================================
Coverage 100.00% 100.00%
Complexity 9815 9815
===============================================
Files 523 523
Lines 37888 37888
===============================================
Hits 37888 37888
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Inlining the layout switch into the actionButtons getter put `this.layout =` inside a computed property, which ember/no-side-effects rejects — four errors, and lint:js took the Ember CI build down. Put the assignment back behind the `changeLayout` action the getter had replaced, now persisting the choice to appCache, and let both menu items call it. Also strip the trailing whitespace and restore the final newlines that prettier flagged in card.js and this file.
A local symlink into a sibling checkout slipped into the previous commit and broke `pnpm install` in CI with ENOTDIR. .gitignore's `/node_modules/` has a trailing slash, so it matches the directory but not a symlink of that name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a "Card View" layout to Drivers Management, mirroring the existing Vehicles Management implementation. Users can now toggle between table and card views, with the preference persisted via appCache.
Changes
Driver::Cardcomponent (addon/components/driver/card.{hbs,js}), modeled directly onVehicle::Card. Displays avatar (viaavatar-urlhelper with driver image fallback), name, phone, status badge (color-mapped the same way ascell/driver-identity), assigned vehicle, and lost modified timestamp. View/edit/delete actions wired to thedriverActionsservice.ManagementDriversIndexControllerto persist the layout preference (fleetops:drivers:layout) viaappCache, and add a table/grid toggle to the action buttons, mirroring the Vehicles controller.Layout::Ressource::Tabular(table) orLayout::Resource::CardsGrid+Driver::Card(grid), matching the Vehicles index template structure.Commits
feat(driver): add driver card componentfeat(drivers): persist card/table layout preferencefeat(drivers): add card view layout toggle to drivers indexTesting
Reference
Mirrors the existing card view implementation in Vehicles Management (
Vehicle::Card,Layout::Resource::CardsGrid).Closes #178