Skip to content

fix(battery_plus): invoke client.close() on Linux batteryState getter #3967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chiliec wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −1
Open

fix(battery_plus): invoke client.close() on Linux batteryState getter #3967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/battery_plus/battery_plus/lib/src/battery_plus_linux.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class BatteryPlusLinuxPlugin extends BatteryPlatform {
return client
.connect()
.then((_) => client.displayDevice.state.toBatteryState())
.whenComplete(() => client.close);
.whenComplete(() => client.close());
}

/// Fires whenever the battery state changes.
Expand Down
11 changes: 11 additions & 0 deletions packages/battery_plus/battery_plus/test/battery_plus_linux_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,17 @@ void main() {
expect(battery.batteryState, completion(BatteryState.charging));
});

test('battery state closes the client', () async {
late MockUPowerClient client;
final battery = BatteryPlusLinuxPlugin();
battery.createClient = () {
client = createMockClient(state: UPowerDeviceState.charging);
return client;
};
await battery.batteryState;
verify(client.close()).called(1);
});

test('battery state changes', () {
final battery = BatteryPlusLinuxPlugin();
battery.createClient = () {
Expand Down
Loading