Add configurable save folders on Android - #2401
Open
JoeysRetroHandhelds wants to merge 1 commit into
Open
JoeysRetroHandhelds wants to merge 1 commit into
JoeysRetroHandhelds wants to merge 1 commit into
Conversation
Route VMU, savestate, and game-save (NVRAM/EEPROM/card) I/O through hostfs::storage() instead of raw FILE*/nowide calls so these paths work with SAF-backed custom folders on Android, and add a migration flow to move or delete existing saves when a new folder is picked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added code so that users can choose where to move or write saves to (for VMU, Savestates & Game Saves).
In General, under Custom Paths, added three new options for VMU Folder, Savestate Folders & Game Save Folder. Users can click Add, navigate using SAF and choose a different directory to store data in. If there already is saves, it will ask the user if they want to move them to this new directory as well. Choosing not to will delete so there's no leftover files.
The main reason for this PR and code is there are devices that cannot access scoped storage and so can't backup saves easily, can't access the saves, and so on. Newer devices lock scoped storage access, this lets users have access to them.
This was tested on my end using a few devices, everything seems to work as intended - but could use more testers on this to triple check.
Created with the help of Claude AI.