Repository navigation
Evaluate compiler-produced conjunctive input guards within runtime limits - #914
Merged
Merged
Conversation
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 7 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
flyingrobots
changed the title
flyingrobots
marked this pull request as ready for review
October 19, 2026 02:54
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A public compiler/verifier-accepted flat-text package failed pure runtime decoding because its conjunctive input guard was encoded as
all, while the runtime only decoded individual comparisons. The same unchanged package now executes and rejects failed range guards.The runtime decodes closed, nonempty conjunction trees, checks every child before execution, and evaluates them in order with short circuiting. Every visited predicate uses the existing execution meter; recursive predicates share the expression/helper node and depth limits. Empty conjunctions reject as
InvalidArtifact, matching Core's one-or-more wire cardinality. Application semantics remain in the authored source.Validation:
InvalidArtifactbefore the fix and is GREEN against the same package pin and accepted verifier report.native_rule_bootstrap,trusted_runtime,host_test,delta_validatefeature set as CI. Feature-gated test registration, fixture licensing, formatting, shell syntax and diff checks pass.CI and local full-test routes explicitly schedule the new trusted-runtime regression. The architecture owner and changelog describe the supported behavior. The fixture retains exact source, raw hashes, package and independent report from Edict
23378720and Echo's checked provider at6a7c62ff; no IR, package or report was edited. No dependency was added.Hosted checks are running on the latest head. This does not complete Jedit's UTF-8/no-op/resource refusal work, persistent rope, mutation admission, Tick or recovery integration. Those remain separate requirements under Jedit #302.