Repository navigation
Expand explorer folders inline and highlight file previews - #349
Draft
flyingrobots wants to merge 3 commits into
Draft
flyingrobots wants to merge 3 commits into
flyingrobots wants to merge 3 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Let users expand Files directories inline with click or Enter and read syntax-highlighted file previews without opening a buffer.
Plan
Current status
Implemented and pushed at 26bba00. Folder click/Enter toggle immediate children in place; Right/l and Left/h navigate hierarchy. File click selects/previews and Enter explicitly opens. Filtering retains ancestors and selects the actual match. Refresh collapses the tree at the same root.
Read-only previews use Graft syntax roles with no editor-head basis. Open-buffer text is preferred; stale results and parser failures are safe. Tabs, wide Unicode and the truncation notice have alignment coverage.
Local full check passed 907 tests: 895 passed, 12 existing skips, zero failures. Quality has no regressions, and all 140 specs belong to a CI shard. Full hosted checks are running on the pushed head.
Native witnesses show mouse and Enter expansion, colored source, filtered hierarchy, dark 100x32/60x12 and Arabic/light 60x16. Previewing produced 13 syntax spans while textRequestId stayed 0 and authority stayed none; only explicit file Enter opened an Echo buffer. Arabic rasterization proves cell alignment, not terminal-specific shaping.
Stacked on footer PR #344. Dojo Feed PR #347 remains separate.
Closes #348.