Skip to content

MDEXP-930 - Reduce log noise and duplication in mod-data-export - #718

Open
khandramai wants to merge 1 commit into
masterfrom
MDEXP-930
Open

MDEXP-930 - Reduce log noise and duplication in mod-data-export#718
khandramai wants to merge 1 commit into
masterfrom
MDEXP-930

Conversation

@khandramai

Copy link
Copy Markdown
Contributor

MDEXP-930 - Reduce log noise and duplication in mod-data-export

Purpose

Reducing of log noise

Approach

Refactoring and logs optimization

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?

    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • Check logging
    • There are no major code smells or security issues
  • Does this introduce breaking changes?

    • Were any API paths or methods changed, added or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added, or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@khandramai
khandramai force-pushed the MDEXP-930 branch 2 times, most recently from 47c970c to 1bea2af Compare September 7, 2026 23:25
@khandramai khandramai self-assigned this Sep 8, 2026
@khandramai
khandramai requested a review from a team September 8, 2026 06:56
@khandramai
khandramai force-pushed the MDEXP-930 branch 3 times, most recently from 1140080 to 504b20c Compare September 8, 2026 10:56
@sonarqubecloud

sonarqubecloud Bot commented Sep 8, 2026

Copy link
Copy Markdown

@khandramai khandramai added AI AI was used for code writing do-not-merge labels Sep 8, 2026
@khandramai

Copy link
Copy Markdown
Contributor Author

Do not merge - it's postponed, partially implemented in #719.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI AI was used for code writing do-not-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant