Skip to content

UIU-3630: fix version history crash on contact types - #3073

Merged
slaemmer merged 3 commits into
masterfrom
UIU-3630
Sep 21, 2026
Merged

slaemmer merged 3 commits into
masterfrom
UIU-3630

Conversation

@slaemmer

@slaemmer slaemmer commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

UIU-3630

Purpose

Bug

Open any user, click "Version history", the pane dies and throws.

It happens for every user, no matter what changed. It even happens on a user that was never edited.

Reason

The contact types list changed shape in PR #3063. id became value, and desc became label (now a ready made ). See the change to contactTypes.js.

This line never got updated and still asks for the old id and desc: useUserVersionHistoryFormatters.js:115

type.desc no longer exists, so the key is empty and it throws. This list is built every time the pane opens and does not depend on the user, so it always crashes.

Approach

Update line.

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • There are no breaking changes in this PR.

@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown

Jest Unit Test Results

    1 files  ±0    294 suites  ±0   5m 40s ⏱️ +48s
1 583 tests +4  1 580 ✅ +4  3 💤 ±0  0 ❌ ±0 
1 619 runs  +4  1 616 ✅ +4  3 💤 ±0  0 ❌ ±0 

Results for commit 2e2f96d. ± Comparison against base commit 9e0f1b4.

♻️ This comment has been updated with latest results.

@slaemmer
slaemmer requested a review from a team September 16, 2026 13:48
@Dmitriy-Litvinenko
Dmitriy-Litvinenko requested a review from a team September 16, 2026 14:06
@sonarqubecloud

Copy link
Copy Markdown

@slaemmer
slaemmer merged commit 65adc70 into master Sep 21, 2026
16 checks passed
@slaemmer
slaemmer deleted the UIU-3630 branch September 21, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants