Repository navigation
Restore accessible AcroForm options and explicit field font sizes - #1805
Conversation
|
Please resolve the conflicts |
|
Resolved the changelog conflict by merging master at e2fafd2. The original form and structure changes and their regression tests are unchanged. Revalidated on Node 24.19.0:
The previously documented post-edit font conformance limits still apply. |
|
Sorry it ended to conflicting again. I tried to resolve conflict myself but i could not (seems you unchecked the option to allow maintainer to update the PR) Feel free, to either resolve the conflict again or let me update the repository directly (in later case you loose automatic github attribution) |
|
Resolved the conflict again in c361d60 by merging master at 50af0aa. The form/structure source and regression tests are unchanged. The changelog entry now sits at the end of Unreleased, which also avoids the same overlap when a new entry is prepended. Lint, formatting, build and package-entry checks passed. The regenerated two-page sample passed veraPDF's PDF/UA-1 profile (106 rules, 593 checks), and two programmatic fill/save/reopen cycles preserved its values and structure links. The previously documented post-edit font limitations still apply. The full local suite is not green: 561/565 tests passed, with four visual tests hitting their existing 8-second timeout ( |
What kind of change does this PR introduce?
Fixes #1803. Tagged form widgets can now receive
alternateName(/TU) andstructParentthrough the public form methods. An explicitly suppliedfontSizealso applies when the field uses the default form font; omitting it preserves inherited appearance behavior.The structure reference captures the widget's page when it is created. Otherwise, adding a later page before finalizing the structure writes an OBJR pointing to that later page. Tests cover this delayed finalization together with nested field membership, distinct structure parents, Unicode/empty names, and explicit zero sizing.
Validation
yarn test --maxWorkers=4: 61 files, 536 tests passed. The unrestricted run timed out in four visual tests; the four-worker run kept the existing 8-second timeout.yarn lint,yarn build,yarn test:package, and formatting checks passed.ua1profile: 106 rules and 593 checks, zero failures. The same local workflow passed through a CommonJS esbuild bundle with registered standard-font metrics.Reproduction, source patch, sample PDF and detailed validation limits.
Checklist