Repository navigation
fix: render the end state when a view animation completes - #420
Merged
Merged
Conversation
Issue: After switching a tile to full screen, the blue focus tint from the expand animation stayed on screen, sometimes briefly and sometimes until the mouse moved. Solution: The frame loop only demanded frames while a view mode was still animating. On the iteration that moved the mode to its end state nothing demanded a frame, so the last in-between frame (drawn as a focused grid tile with its blue fill) stayed presented until unrelated output or input arrived. The frame scheduler now has an explicit animation_settled demand that the runtime sets whenever an expand, collapse, pan, or grid-resize animation completes, so the end state is rendered immediately.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the animation settle-frame change, though builds and tests were not run during review.
No open issues 🎉
What changed in this PR
Fixes lingering animation visuals in Architect by requesting an immediate final frame when a view animation completes, without keeping continuous rendering active.
Changes:
- Reports completion of expand, collapse, pan, and grid-resize animations to the frame scheduler.
- Adds an
animation_settleddemand and a regression test for immediate end-state rendering. - Documents the settle-frame requirement in
CLAUDE.md.
Builds and tests were not run during this review.
| File | Description |
|---|---|
src/app/runtime.zig |
Signals animation completion to request a final frame. |
src/app/frame_schedule.zig |
Adds immediate settle-frame demand and regression coverage. |
CLAUDE.md |
Documents the final-frame scheduling requirement. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
When you open a terminal in full screen, a blue tint from the opening animation can stay on the screen. It stays until the terminal shows new output or you move the mouse. This change makes the app draw one more frame when an animation ends, so the tint goes away immediately.
Issue
After expanding a grid tile to full screen, the blue focus tint (the fill and border drawn on a focused grid tile) stayed visible on the expanded terminal. With an active terminal it went away after a moment; with an idle one it stayed until the mouse moved.
The frame loop demands frames only while the view mode is animating. On the loop iteration that moves the mode to its end state (for example
Expanding→Full), the mode no longer counts as animating, and nothing else asks for a frame. The last presented frame is therefore an in-between one, rendered as a focused grid tile, and it stays until terminal output or user input triggers a repaint. Pans between full-screen sessions had the same gap. Collapse and grid resize happened to work because their completion marks sessions dirty, but they still waited for the output cadence.Solution
frame_schedule.Demandgainsanimation_settled, an interactive (render-now) demand that does not keep continuous pacing.CLAUDE.mdrecords the rule so new view-mode transitions report their settle frame.Test plan