Skip to content

fix: redact Hetzner errors and retry transient balancer deletion - #63

Merged
pando85 merged 9 commits into
masterfrom
fix/hetzner-error-reporting-and-cleanup-retries
Oct 13, 2026
Merged

pando85 merged 9 commits into
masterfrom
fix/hetzner-error-reporting-and-cleanup-retries

Conversation

@pando85

@pando85 pando85 commented Oct 13, 2026 •

Copy link
Copy Markdown

Summary

  • Report all reconciliation failures as Kubernetes Warning Events on the affected Service, including invalid annotations, finalizer cleanup and Hetzner errors. Keep the existing InvalidLoadBalancerConfiguration reason; use SyncLoadBalancerFailed for other failures.
  • Redact Hetzner API tokens (and quoted prefixes >=8 bytes) in controller error logs and Events, and safely truncate Event notes to Kubernetes' 1024-byte limit at a UTF-8 boundary.
  • Apply the existing bounded 409/423/5xx/robot_unavailable retry helper to both LB deletion entry points before removing the finalizer. Do not retry permanent errors or project-wide 429s.
  • Throttle identical Warning Events to once per five minutes per Service UID, reason and redacted message. Different errors publish immediately; concurrent reconciles share an atomic reservation, and failed Event writes release the reservation. Expired entries are pruned.
  • Add tests covering redaction, Event notes, throttling/expiry, distinct errors, concurrent reservations and transient/permanent delete response handling.

Notes

Validation

CI runs cargo fmt, cargo clippy --all-targets -- -D warnings, cargo test --all-targets --locked and Helm unit tests.

@forkline

forkline Bot commented Oct 13, 2026

Copy link
Copy Markdown

The clippy collapsible_if error and rustfmt formatting issues were already fixed in commit 5ef1b7f. The nested if blocks were collapsed and tracing macro calls were reformatted. No additional changes needed.

@forkline

forkline Bot commented Oct 13, 2026

Copy link
Copy Markdown

✅ Fix pushed:

The CI issues (clippy collapsible_if lint and rustfmt formatting) were already fixed in commit 5ef1b7f. The branch is up to date with origin - no additional changes needed.

@forkline

forkline Bot commented Oct 13, 2026

Copy link
Copy Markdown

⏸️ CI Auto-Fix paused

A user commit was detected after an automated fix. CI auto-fix is now paused
to prevent conflicts with your changes.

To resume CI auto-fix, use the /reset or /reset-ci-auto-fix command.

@pando85
pando85 merged commit 8531b8f into master Oct 13, 2026
2 checks passed
@pando85
pando85 deleted the fix/hetzner-error-reporting-and-cleanup-retries branch October 13, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant