Skip to content

Add feedback/suggestion forms to Glossary and Adopting Principled Education pages - #872

Merged
LukasWallrich merged 11 commits into
mainfrom
glossary-feedbackform
Sep 3, 2026
Merged

Add feedback/suggestion forms to Glossary and Adopting Principled Education pages#872
LukasWallrich merged 11 commits into
mainfrom
glossary-feedbackform

Conversation

@richarddushime

@richarddushime richarddushime commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Description

Adds two native feedback forms, on individual glossary term pages and the "Adopting Principled Education" page, that submit directly to a Google Sheet via a shared Google Apps Script backend, no third-party form embed required.

Glossary entry pages

New "Suggest an improvement" form (correction / suggestion / other, message, optional email), translated into all 5 glossary languages, RTL-aware for Arabic.
Submits to a glossary_feedback sheet tab

Adopting Principled Education page

APE feedback form (tips used, what worked, student demographics, comments) matching the page's existing "share your experience" call-to-action, replacing a dead/empty Google Form link.
Submits to a separate adopting_feedback sheet tab in the same spreadsheet.

Appscript
.feedback-appscript/Code.js now dispatches on a type field to route chat / glossary / adopting submissions to their own created sheet tabs in one shared Apps Script deployment.

Fixes #743

Type of Change

  • Content/documentation update
  • New feature

Testing

Checklist

  • Self-reviewed my changes
  • Verified links and formatting are correct
  • No new warnings or errors

Notes

@richarddushime
richarddushime requested a review from a team as a code owner August 26, 2026 17:40
@richarddushime richarddushime changed the title Add feedback/suggestion forms to Glossary and Adopting Principled Education pages [Draft] Add feedback/suggestion forms to Glossary and Adopting Principled Education pages Aug 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👍 All image files/references (if any) are in webp format, in line with our policy.

@richarddushime richarddushime changed the title [Draft] Add feedback/suggestion forms to Glossary and Adopting Principled Education pages [In progress] Add feedback/suggestion forms to Glossary and Adopting Principled Education pages Aug 26, 2026
@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

📝 Spell Check Results

Found 6 potential spelling issue(s) when checking 61 changed file(s):

📄 layouts/glossary/single.html

Line Issue
32 Referenz ==> Reference

📄 layouts/partials/glossary_feedback_form.html

Line Issue
27 oder ==> order, older, coder, odder, odor, over, doer
27 oder ==> order, older, coder, odder, odor, over, doer
31 Referenz ==> Reference
34 oder ==> order, older, coder, odder, odor, over, doer
59 bu ==> by, be, but, bug, bun, bud, buy, bum

ℹ️ How to address these issues:

  1. Fix the typo: If it's a genuine typo, please correct it.
  2. Add to whitelist: If it's a valid word (e.g., a name, technical term), add it to .codespell-ignore.txt
  3. False positive: If this is a false positive, please report it in the PR comments.

🤖 This check was performed by codespell

@LukasWallrich

LukasWallrich commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Staging Deployment Status

This PR has been successfully deployed to staging as part of an aggregated deployment.

Deployed at: 2026-09-03 11:54:23 UTC
Staging URL: https://staging.forrt.org

The staging site shows the combined state of all compatible open PRs.

@LukasWallrich

Copy link
Copy Markdown
Contributor

Pushed one commit that points the script and both client scripts at the existing FORRT feedback sheet and web app (the PR had the contributor's own sheet ID and deployment URL). The web app is already redeployed with this PR's Code.js, so the endpoint is live and the PR can be merged whenever ready. Verified end to end: test submissions of both types created the glossary_feedback and adopting_feedback tabs with the expected headers (test rows removed).

@richarddushime richarddushime changed the title [In progress] Add feedback/suggestion forms to Glossary and Adopting Principled Education pages Add feedback/suggestion forms to Glossary and Adopting Principled Education pages Sep 2, 2026
@richarddushime

Copy link
Copy Markdown
Contributor Author

@LukasWallrich
This is ready

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

There are correctness/accessibility issues in the new feedback plumbing (Apps Script chat sheet creation robustness and adopting form markup/behavior) that should be addressed before merging.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR adds two native feedback/suggestion forms (for glossary term pages and the “Adopting Principled Education” page) that post JSON to a shared Google Apps Script backend, routing submissions into separate sheet tabs via a type discriminator.

Changes:

  • Add a new glossary “Suggest an improvement” form (translated across glossary languages) and a dedicated client script to POST to Apps Script.
  • Add a new “Adopting Principled Education” feedback form + client script to POST to Apps Script.
  • Update the Apps Script receiver to dispatch by data.type (chat / glossary / adopting) into dedicated sheets, and update chat payloads to include type: "chat".
File summaries
File Description
static/js/just-os-chat.js Adds a type: "chat" field to chat feedback payloads to support Apps Script routing.
static/js/glossary-feedback.js New client-side handler for glossary term feedback form submissions.
static/js/adopting-feedback.js New client-side handler for the adopting feedback form, including UI toggles and submission logic.
layouts/shortcodes/adopting_feedback_form.html New shortcode defining the adopting feedback form markup, styling, and script include.
layouts/partials/glossary_feedback_form.html New partial defining the glossary feedback form markup, styling, and translation strings.
layouts/glossary/single.html Renders the glossary feedback form partial on glossary term pages.
content/adopting/adopting.md Replaces the dead Google Form reference with the new inline form shortcode.
.feedback-appscript/Code.js Updates Apps Script backend to route submissions by type into separate sheets and auto-create sheets/headers.
Review details
  • Files reviewed: 8/8 changed files
  • Comments generated: 3
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .feedback-appscript/Code.js
Comment thread layouts/shortcodes/adopting_feedback_form.html Outdated
Comment thread content/adopting/adopting.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

@LukasWallrich LukasWallrich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - made minor changes based on code review

@LukasWallrich
LukasWallrich merged commit d9c2de2 into main Sep 3, 2026
3 checks passed
@LukasWallrich
LukasWallrich deleted the glossary-feedbackform branch September 3, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Feedback/Suggestion Form to Glossary Entry Page

3 participants