Skip to content

chore(ci): re-pin dtolnay/rust-toolchain v1 - #17499

Merged
stevencartavia merged 1 commit into
masterfrom
steven/repin-rust-toolchain
Oct 9, 2026
Merged

stevencartavia merged 1 commit into
masterfrom
steven/repin-rust-toolchain

Conversation

@stevencartavia

Copy link
Copy Markdown
Member

The v1 tag of dtolnay/rust-toolchain was moved upstream to e2a55d2 ("Safely handle action inputs", dtolnay/rust-toolchain#187), so every existing @7e38f4b… # v1 pin now has a mismatched version comment. zizmor's ref-version-mismatch audit fails the Workflow Validation job (and therefore ci-success) on every PR, for example #17493. This re-pins all 21 uses to the current v1 commit, like #17269. The upstream change only hardens how the action passes its inputs to the shell.

@grandizzy grandizzy left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! What we can also do is to use the vendored one which we maintain (and also protect against such changes) like in https://github.com/tempoxyz/tempo/blob/feb5dff7dac707d594cc326f0dd5d242180323bf/.github/workflows/lint.yml#L42

@stevencartavia
stevencartavia enabled auto-merge (squash) October 9, 2026 04:04
@stevencartavia
stevencartavia merged commit e2c787b into master Oct 9, 2026
30 checks passed
@stevencartavia
stevencartavia deleted the steven/repin-rust-toolchain branch October 9, 2026 04:09
stevencartavia added a commit that referenced this pull request Oct 21, 2026
stevencartavia added a commit that referenced this pull request Oct 21, 2026
Cherry-picks onto v1.8.5 for the v1.8.6 patch release:

- #17411 chore: bump version to 1.8.6
- #17499 chore(ci): re-pin dtolnay/rust-toolchain v1
- #17553 chore(deps): bump the ci-weekly group with 5 updates
- #17572 fix(deps): update rustls for security advisories
- #17612 fix(ci): stop rust-toolchain tag drift failures
- #17621 chore(deps): bump the ci-weekly group across 1 directory with 6 updates
- #17630 chore(deps): bump svm to 0.5.30
- #17661 chore(deps): bump Soldeer to 0.12.1
- #17687 fix(ci): install Vyper without source builds
- #17705 chore: update deps
- #17422 test(cast): update Amsterdam trace snapshot

Also drops the stale soldeer git allowlist entry from deny.toml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants