Repository navigation
test: isolate no-key config tests from local config file - #44
Merged
Merged
Conversation
TestConfiguration::test_client_raises_without_key and test_whitespace_only_api_key_rejected now patch Configuration._load_api_key to return None, so a key stored in ~/.bloomy/config.yaml no longer makes them fail with "DID NOT RAISE ConfigurationError". Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestConfiguration::test_client_raises_without_keyandtest_whitespace_only_api_key_rejectedonly clearedBG_API_KEY, so on any machine with a key stored in~/.bloomy/config.yamlthe client loaded that key and the tests failed with "DID NOT RAISE ConfigurationError".Fix
Both tests now patch the config file lookup:
monkeypatch.setattr(Configuration, "_load_api_key", lambda _self: None)Verification
ruff check/ruff format: cleanpyright: 0 errors🤖 Generated with Claude Code