Repository navigation
docs: fix stale facts in Claude instructions and dev docs - #45
Merged
Merged
Conversation
Audit CLAUDE.md and the .claude/agents subagent definitions for outdated content: - Use `uv run basedpyright`; `uv run pyright` falls through to a global pyright that ignores the [tool.basedpyright] config CI uses (also fixed in README and CONTRIBUTING) - Release steps go through a PR and tag the merge commit, matching the PR-only rule and actual history; drop the duplicate bump procedure - Replace copied ruff/pyright config with a pointer to pyproject.toml - Fix nonexistent test IDs and fixture signatures - Add the transform-mixin step to the feature template - Replace hardcoded tag ranges, drop `git rebase -i` - Remove emphasis and the subagent table from the delegation section Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- Point code-quality-reviewer to pyproject.toml and quality.yml instead of listing CI steps; consult them only when a setting is in question - Add the transform mixin to api-feature-developer's checklist and drop the Step 2 text that repeated the overview - Align version-control-engineer's commit example with the release steps, create the release branch first, and remove redundant steps - Name sdk-test-engineer fixtures and point to conftest.py instead of copying their signatures Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An audit of
CLAUDE.mdand the.claude/agents/subagent definitions found instructions that no longer match the code or contradict each other. This PR fixes them. No library code changes.Changes
uv run pyrightresolves to a global pyright that ignores[tool.basedpyright], so it doesn't check what CI checks. Replaced withuv run basedpyrightinCLAUDE.md,code-quality-reviewer,version-control-engineer,README.mdandCONTRIBUTING.md.version-control-engineer): the release steps committed onmainand rangit push origin main --tags, which contradicted the agent's own "Always create PRs for main" rule. They now go branch → PR → tag the merge commit, which matches how releases have actually been done. Removed the duplicate "Version Bump Process" and used thechore(release): bump version to X.Y.Zcommit message from history.code-quality-reviewer): the ruff rule list had drifted (it was missingRUFandpreview = true). Replaced it with a pointer topyproject.tomlandquality.yml.test_user_details,TestUserOperations::test_details) and fixture signatures that don't matchconftest.py.api-feature-developer): added the*_transformmixin step that every operations class uses, and pointed to the headlines resource as the reference implementation.v0.19.0..HEADandv0.18.0..HEADranges with the latest tag, and removedgit rebase -i, which can't run in Claude Code's non-interactive shell.CLAUDE.md): removed theIMPORTANT/PROACTIVELYemphasis and the subagent table (the harness already lists the agents). Added the reason for delegating and an exception for one- or two-line changes.Test plan
uv run basedpyright: 0 errorsuv run pytest tests/test_users.py::TestUserOperations::test_details_basicpassesuv run pyright, stale test IDs, hardcoded tag ranges orrebase -iin the changed files🤖 Generated with Claude Code