Repository navigation
fix(utils): match DISALLOWED_NAMES case-insensitively - #354
Open
jamalkamaladdin wants to merge 2 commits into
Open
jamalkamaladdin wants to merge 2 commits into
jamalkamaladdin wants to merge 2 commits into
Conversation
is_valid_name lowercases the name, but the attorney general entries are capitalized, so none of them matched. A missing comma after "commissioner" also fused it with "Akerman". Lowercase both sides of the comparison and add the comma. Fixes freelawproject#351
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #351
Summary
is_valid_namecomparedname.lower()againstDISALLOWED_NAMES. Attorney general entries in that list are capitalized, and none of them could ever hit. A missing comma after"commissioner"joined it with"Akerman"into one string.is_valid_namenow lowercases eachDISALLOWED_NAMESentry before comparing. Added the missing comma.Foo v. Ashcroft, 1 U.S. 12 (2001). See Ashcroft at 62.no longer yields anAshcroft at 62reference citation. Common surnames on that list, such as Smith, Johnson and Miller, now failis_valid_nametoo.New test
test_is_valid_name_disallowedintests/test_UtilsTest.py. Added aCHANGES.mdentry.AI Disclosure