Repository navigation
fix: create stable Node runtime blocker for local ESLint - #12
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1b4c6c2542
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| observe_with_preparation_reason( | ||
| &args, | ||
| deadline, | ||
| Some("eslint_node_runtime_unresolved"), |
There was a problem hiding this comment.
When two TypeScript files in the same project-local ESLint module are scanned without Node on PATH, this new path creates two environment tasks rather than updating one: observe_with_preparation_reason passes the per-file args, and eslint_preparation::prepare includes that source-relative path in the blocker fingerprint. The test only repeats one file, so it misses the task pileup across files; key this runtime blocker to the discovered candidate root/checking obligation instead.
Useful? React with 👍 / 👎.
1 participant
When a project-local ESLint package and flat config are visible but the current
PATHhas no usable Node executable, the TypeScript lint candidate previously reported onlyeslint_execution_context_missing. It now reportseslint_node_runtime_unresolvedand, in an initialized workspace, updates one stable environment task whose next step asks for a controlled Node path and native recheck. A repeated scan does not create another blocker or suggest reinstalling ESLint or editing unrelated source.This advances OpenSpec S14.10 without claiming that syntax confirmation tasks, multi-module dispatch or full delivery gates are complete.
Validation: the missing-Node assertion failed before the change; afterward 18 targeted tests passed, 4 real-ESLint tests remained ignored. Feature Clippy with
-D warnings, fmt, layering, OpenSpec strict and diff checks passed. The acceptance record and task ledger were updated.